fix: don't use #[naked] when inlining is paramount for correctness

yvt · yvt · commit 32d5fdc62437 · 2020-12-06T16:38:33.000+09:00
Functions with `#[naked]` are no longer eligible for inlining as of <rust-lang/rust#79192>. Fixes test failures in the RISC-V port.
diff --git a/src/r3_port_arm/src/startup/imp.rs b/src/r3_port_arm/src/startup/imp.rs
@@ -30,7 +30,6 @@ impl VectorTable {
     }
 }
 
-#[naked]
 #[inline(always)]
 pub fn start<System: EntryPoint + StartupOptions>() {
     unsafe {
diff --git a/src/r3_port_riscv/src/threading/cfg.rs b/src/r3_port_riscv/src/threading/cfg.rs
@@ -61,7 +61,6 @@ macro_rules! use_port {
                     unsafe { PORT_STATE.port_boot::<Self>() };
                 }
 
-                #[naked]
                 #[inline(always)]
                 unsafe fn exception_handler() -> ! {
                     unsafe { State::exception_handler::<Self>() };
diff --git a/src/r3_port_riscv/src/threading/imp.rs b/src/r3_port_riscv/src/threading/imp.rs
@@ -1113,7 +1113,6 @@ impl State {
     }
 
     /// Implements [`crate::EntryPoint::exception_handler`].
-    #[naked]
     #[inline(always)]
     pub unsafe fn exception_handler<System: PortInstance>() -> ! {
         const FRAME_SIZE: usize = if cfg!(target_feature = "f") {

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,6 @@ impl VectorTable {`
`30`	`30`	`}`
`31`	`31`	`}`
`32`	`32`
`33`		`-#[naked]`
`34`	`33`	`#[inline(always)]`
`35`	`34`	`pub fn start<System: EntryPoint + StartupOptions>() {`
`36`	`35`	`unsafe {`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,6 @@ macro_rules! use_port {`
`61`	`61`	`unsafe { PORT_STATE.port_boot::<Self>() };`
`62`	`62`	`}`
`63`	`63`
`64`		`- #[naked]`
`65`	`64`	`#[inline(always)]`
`66`	`65`	`unsafe fn exception_handler() -> ! {`
`67`	`66`	`unsafe { State::exception_handler::<Self>() };`
Original file line number	Diff line number	Diff line change
`@@ -1113,7 +1113,6 @@ impl State {`
`1113`	`1113`	`}`
`1114`	`1114`
`1115`	`1115`	/// Implements [`crate::EntryPoint::exception_handler`].
`1116`		`- #[naked]`
`1117`	`1116`	`#[inline(always)]`
`1118`	`1117`	`pub unsafe fn exception_handler<System: PortInstance>() -> ! {`
`1119`	`1118`	`const FRAME_SIZE: usize = if cfg!(target_feature = "f") {`