[Cocoa] Add handler for javascript prompt/input. (#1567)

* [Cocoa] Add handler for javascript prompt/input.

Cocoa was missing handler for calling prompt("...")

This adds the popup and input handling

* [Cocoa] Add edit menu to get cut/copy/paste/selectAll on submenus, alerts, etc.

The existing implementation in the keyDown_ handler only works on items in the main view and not in subviews/modals

Author: maddyaby

webview/localization.py

@@ -9,11 +9,16 @@
     'cocoa.menu.about': 'About',
     'cocoa.menu.services': 'Services',
     'cocoa.menu.view': 'View',
+    'cocoa.menu.edit': 'Edit',
     'cocoa.menu.hide': 'Hide',
     'cocoa.menu.hideOthers': 'Hide Others',
     'cocoa.menu.showAll': 'Show All',
     'cocoa.menu.quit': 'Quit',
     'cocoa.menu.fullscreen': 'Enter Fullscreen',
+    'cocoa.menu.cut': 'Cut',
+    'cocoa.menu.copy': 'Copy',
+    'cocoa.menu.paste': 'Paste',
+    'cocoa.menu.selectAll': 'Select All',
     'windows.fileFilter.allFiles': 'All files',
     'windows.fileFilter.otherFiles': 'Other file types',
     'linux.openFile': 'Open file',

webview/platforms/cocoa.py

@@ -207,6 +207,17 @@ def webView_runJavaScriptConfirmPanelWithMessage_initiatedByFrame_completionHand
             result = BrowserView.display_confirmation_dialog(ok, cancel, message)
             handler(result)
 
+        # Display a Javascript input panel
+        def webView_runJavaScriptTextInputPanelWithPrompt_defaultText_initiatedByFrame_completionHandler_(
+            self, webview, prompt, default_text, frame, handler
+        ):
+            i = BrowserView.get_instance('webview', webview)
+            ok = i.localization['global.ok']
+            cancel = i.localization['global.cancel']
+
+            result = BrowserView.display_input_dialog(ok, cancel, prompt, default_text)
+            handler(result)
+
         # Display an open panel for <input type="file"> element
         def webView_runOpenPanelWithParameters_initiatedByFrame_completionHandler_(
             self, webview, param, frame, handler
@@ -656,6 +667,7 @@ def first_show(self):
             self._clear_main_menu()
             self._add_app_menu()
             self._add_view_menu()
+            self._add_edit_menu()
             self._add_user_menu()
 
             BrowserView.app.activateIgnoringOtherApps_(Foundation.YES)
@@ -1064,6 +1076,34 @@ def _add_view_menu(self):
             AppKit.NSControlKeyMask | AppKit.NSCommandKeyMask
         )
 
+    def _add_edit_menu(self):
+        """
+        Create a default Edit menu that shows Copy/Paste/etc.
+        """
+        mainMenu = BrowserView.app.mainMenu()
+
+        if not mainMenu:
+            mainMenu = AppKit.NSMenu.alloc().init()
+            BrowserView.app.setMainMenu_(mainMenu)
+
+        # Create an Edit menu and make it a submenu of the main menu
+        editMenu = AppKit.NSMenu.alloc().init()
+        editMenu.setTitle_(self.localization['cocoa.menu.edit'])
+        editMenuItem = AppKit.NSMenuItem.alloc().init()
+        editMenuItem.setSubmenu_(editMenu)
+        # Make the edit menu the first item after the application menu
+        mainMenu.insertItem_atIndex_(editMenuItem, 1)
+
+        for (title, action, keyEquivalent) in [
+            (self.localization['cocoa.menu.cut'], 'cut:', 'x'),
+            (self.localization['cocoa.menu.copy'], 'copy:', 'c'),
+            (self.localization['cocoa.menu.paste'], 'paste:', 'v'),
+            (self.localization['cocoa.menu.selectAll'], 'selectAll:', 'a'),
+        ]:
+            menuItem = editMenu.addItemWithTitle_action_keyEquivalent_(
+                title, action, keyEquivalent
+            )
+
     def _append_app_name(self, val):
         """
         Append the application name to a string if it's available. If not, the
@@ -1128,6 +1168,29 @@ def display_confirmation_dialog(first_button, second_button, message):
 
         return alert.runModal() == AppKit.NSAlertFirstButtonReturn
 
+    @staticmethod
+    def display_input_dialog(first_button, second_button, prompt, default_text):
+        AppKit.NSApplication.sharedApplication()
+        AppKit.NSRunningApplication.currentApplication().activateWithOptions_(
+            AppKit.NSApplicationActivateIgnoringOtherApps
+        )
+        alert = AppKit.NSAlert.alloc().init()
+        text_field = AppKit.NSTextField.alloc().initWithFrame_(
+            AppKit.NSMakeRect(0, 0, 240, 24)
+        )
+        text_field.cell().setScrollable_(True)
+        text_field.setStringValue_(default_text)
+        alert.setAccessoryView_(text_field)
+        alert.addButtonWithTitle_(first_button)
+        alert.addButtonWithTitle_(second_button)
+        alert.setMessageText_(prompt)
+        alert.setAlertStyle_(AppKit.NSWarningAlertStyle)
+
+        if alert.runModal() == AppKit.NSAlertFirstButtonReturn:
+            return text_field.stringValue()
+        else:
+            return None
+
     @staticmethod
     def should_close(window):
         quit = window.localization['global.quit']