Skip to content

Commit f222c21

Browse files
moromimayralphrass
authored andcommitted
[BUG] Change logging config (#307)
* Change logging config. * Some adjusts. * Remove a code smell.
1 parent f1f5c76 commit f222c21

File tree

4 files changed

+0
-62
lines changed

4 files changed

+0
-62
lines changed

butterfree/__init__.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1 @@
11
"""Module docstring example, following Google's docstring style."""
2-
import logging.config
3-
import os
4-
import sys
5-
6-
sys.path.insert(0, os.path.abspath("."))
7-
8-
logging.config.fileConfig(fname="butterfree/logging.conf")

butterfree/logging.conf

Lines changed: 0 additions & 52 deletions
This file was deleted.

logs/logging.json

Whitespace-only changes.

tests/unit/butterfree/_cli/test_migrate.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,10 @@ def test_migrate_all_pairs(self, mocker):
1616

1717
class TestMigrate:
1818
def test_migrate_success(self, mocker):
19-
mocker.patch.object(migrate.Migrate, "run")
2019
all_fs = migrate.migrate("tests/mocks/entities/")
2120
assert all(isinstance(fs, FeatureSetPipeline) for fs in all_fs)
2221
assert sorted([fs.feature_set.name for fs in all_fs]) == ["first", "second"]
2322

24-
def test_migrate_run_methods(self, mocker):
25-
mocker.patch.object(CassandraMigration, "apply_migration")
2623
mocker.patch.object(migrate.Migrate, "_send_logs_to_s3")
2724

2825
all_fs = migrate.migrate("tests/mocks/entities/", False, False)

0 commit comments

Comments
 (0)