Skip to content

Commit d0d1d13

Browse files
committed
typo: useColumns → useSkeletonSizes
1 parent 5b70c5a commit d0d1d13

File tree

2 files changed

+18
-5
lines changed

2 files changed

+18
-5
lines changed

catalog/app/containers/Search/Table/Skeleton.tsx

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,29 @@ import * as React from 'react'
22
import * as M from '@material-ui/core'
33
import * as Lab from '@material-ui/lab'
44

5+
interface SkeletonColumn {
6+
key: React.Key
7+
width: number
8+
}
9+
10+
interface SkeletonRow {
11+
key: React.Key
12+
columns: SkeletonColumn[]
13+
}
14+
515
const randomColumnWidth = (min: number = 80, max: number = 200) =>
616
min + Math.floor(Math.random() * (max - min + 1))
717

8-
const createColumns = (columnsLen: number) =>
18+
const createColumns = (columnsLen: number): SkeletonColumn[] =>
919
Array.from({ length: columnsLen }).map((_c, key) => ({
1020
key,
1121
width: randomColumnWidth(),
1222
}))
1323

14-
export const useColumns = (rowsLen: number = 30, columnsLen: number = 5) =>
24+
export const useSkeletonSizes = (
25+
rowsLen: number = 30,
26+
columnsLen: number = 5,
27+
): SkeletonRow[] =>
1528
React.useMemo(
1629
() =>
1730
Array.from({ length: rowsLen }).map((_r, key) => ({
@@ -40,7 +53,7 @@ interface TableProps {
4053
}
4154

4255
export function Table({ className }: TableProps) {
43-
const rows = useColumns()
56+
const rows = useSkeletonSizes()
4457
if (!rows.length) return null
4558
const [head, ...body] = rows
4659
return (

catalog/app/containers/Search/Table/Table.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1124,7 +1124,7 @@ const useLayoutStyles = M.makeStyles((t) => ({
11241124
interface LayoutProps {
11251125
hits: readonly Hit[]
11261126
columns: ColumnsMap
1127-
skeletons: ReturnType<typeof Skeleton.useColumns>
1127+
skeletons: ReturnType<typeof Skeleton.useSkeletonSizes>
11281128
}
11291129

11301130
function Layout({ hits, columns, skeletons }: LayoutProps) {
@@ -1198,7 +1198,7 @@ interface TableViewProps {
11981198
function TableView({ hits, bucket, metaFiltersState }: TableViewProps) {
11991199
const { hiddenColumns } = useContext()
12001200
const [columns, notReady] = useColumns(hiddenColumns, metaFiltersState, bucket)
1201-
const skeletons = Skeleton.useColumns(
1201+
const skeletons = Skeleton.useSkeletonSizes(
12021202
notReady === Workflow.Loading ? hits.length + 1 : 0,
12031203
3,
12041204
)

0 commit comments

Comments
 (0)