refactor: convert post-release-status to pure function design

- All parameters now passed explicitly from GitHub Action
- No environment variable dependencies in script
- is-production flag determines release type (not tag pattern)
- package-name parameter for flexibility
- Improved testability with pure function approach
- Updated tests to match new design
- Decision logic moved to GitHub Action

Author: drernie

.github/actions/create-release/action.yml

@@ -127,14 +127,21 @@ runs:
 
     - name: Post release status
       shell: bash
-      env:
-        GITHUB_TOKEN: ${{ github.token }}
       run: |
+        # Determine if this is a production release
+        IS_PRODUCTION="true"
+        if [[ "${{ inputs.package-version }}" == *"-dev-"* ]] || [[ "${{ inputs.package-version }}" == *"-dev" ]]; then
+          IS_PRODUCTION="false"
+        fi
+
         uv run python scripts/post_release_status.py \
           --version "${{ inputs.package-version }}" \
           --release-url "${{ steps.create-release.outputs.url }}" \
           --pypi-url "${{ steps.package-urls.outputs.pypi-url }}" \
           --docker-image "${{ steps.docker-info.outputs.image-uri }}" \
           --release-id "${{ steps.create-release.outputs.id }}" \
           --sha "${{ github.sha }}" \
-          --repo "${{ github.repository }}"
+          --repo "${{ github.repository }}" \
+          --github-token "${{ github.token }}" \
+          --is-production "${IS_PRODUCTION}" \
+          --package-name "quilt-mcp-server"

scripts/post_release_status.py

@@ -22,9 +22,11 @@ def generate_release_comment(
     release_url: str,
     pypi_url: str,
     docker_image: Optional[str] = None,
+    is_production: bool = True,
+    package_name: str = "quilt-mcp-server",
 ) -> str:
     """Generate the release status comment body."""
-    is_prod = "-dev-" not in version
+    # Use the is_production flag passed explicitly
 
     body = f"## 🚀 Release Status for v{version}\n\n"
     body += "### 📦 Package Locations\n\n"
@@ -39,19 +41,19 @@ def generate_release_comment(
         body += "```\n"
 
     body += "\n### 📥 Installation\n"
-    if is_prod:
+    if is_production:
         body += "```bash\n"
         body += "# Install from PyPI\n"
-        body += f"pip install quilt-mcp-server=={version}\n"
+        body += f"pip install {package_name}=={version}\n"
         body += "# or\n"
-        body += f"uv add quilt-mcp-server=={version}\n"
+        body += f"uv add {package_name}=={version}\n"
         body += "```\n"
     else:
         body += "```bash\n"
         body += "# Install from TestPyPI\n"
-        body += f"pip install -i https://test.pypi.org/simple/ quilt-mcp-server=={version}\n"
+        body += f"pip install -i https://test.pypi.org/simple/ {package_name}=={version}\n"
         body += "# or\n"
-        body += f"uv add --index https://test.pypi.org/simple/ quilt-mcp-server=={version}\n"
+        body += f"uv add --index https://test.pypi.org/simple/ {package_name}=={version}\n"
         body += "```\n"
 
     return body
@@ -258,6 +260,8 @@ def main():
         release_url=args.release_url,
         pypi_url=args.pypi_url,
         docker_image=args.docker_image,
+        is_production=args.is_production,
+        package_name=args.package_name,
     )
 
     if args.dry_run:
@@ -267,13 +271,7 @@ def main():
 
     # PRIMARY GOAL: Update release notes if release-id is provided
     if args.release_id:
-        if not args.github_token:
-            print("Error: GitHub token required to update release notes", file=sys.stderr)
-            return 1
-
-        if not args.repo:
-            print("Error: Repository required to update release notes", file=sys.stderr)
-            return 1
+        # All required parameters are already validated by argparse
 
         # Format content for release notes (add separator)
         release_notes_content = f"\n---\n\n{status_content}"
@@ -294,15 +292,15 @@ def main():
     # SECONDARY GOAL: Post PR comment if possible (failure = graceful continue)
     pr_number = args.pr_number
 
-    if not pr_number and args.sha and args.github_token:
+    if not pr_number and args.sha:
         # Try to find PR from SHA
         pr_number = find_pr_for_sha(
             github_token=args.github_token,
             repo=args.repo,
             sha=args.sha,
         )
 
-    if pr_number and args.github_token and args.repo:
+    if pr_number:
         # Attempt to post PR comment
         pr_success = post_comment_to_pr(
             github_token=args.github_token,

spec/feature-docker-container/14-post-release-status.md

@@ -43,6 +43,22 @@ When a development tag (`v*-dev-*`) is pushed:
 3. **Update the release notes** with formatted status information
 4. Attempt to find associated PR and post comment
 
+## Design Philosophy
+
+### Pure Function Approach
+
+The post-release status script follows a pure function design:
+- All parameters are passed explicitly from the GitHub Action
+- No environment variable dependencies (except GITHUB_TOKEN for API calls)
+- No implicit behavior based on tag patterns or environment
+- All decision logic happens in the GitHub Action, not the script
+- Script focuses solely on formatting and posting status
+
+This design ensures:
+- Testability: All behavior can be tested with explicit inputs
+- Predictability: No hidden dependencies or side effects
+- Maintainability: Clear separation between orchestration (action) and execution (script)
+
 ## Implementation Requirements
 
 ### Release Notes Update (Primary)
@@ -128,16 +144,18 @@ The `create-release` action should output:
 
 ### Script Parameters
 
-The `post_release_status.py` script should accept:
+The `post_release_status.py` script should accept ALL parameters explicitly (pure function design):
 
 - `--release-id`: GitHub release ID for updating notes
 - `--version`: Package version
 - `--release-url`: GitHub release URL
 - `--pypi-url`: PyPI package URL
 - `--docker-image`: Docker image URI (optional)
 - `--sha`: Git SHA for PR detection (optional)
-- `--repo`: Repository identifier
+- `--repo`: Repository identifier (owner/repo format)
 - `--github-token`: API token
+- `--is-production`: Boolean flag for production vs development release
+- `--package-name`: Package name for display (e.g., "quilt-mcp-server")
 
 ### Workflow Steps
 
@@ -159,7 +177,10 @@ The `post_release_status.py` script should accept:
       --pypi-url "${{ steps.package-urls.outputs.pypi-url }}" \
       --docker-image "${{ steps.docker-info.outputs.image-uri }}" \
       --sha "${{ github.sha }}" \
-      --repo "${{ github.repository }}"
+      --repo "${{ github.repository }}" \
+      --github-token "${{ github.token }}" \
+      --is-production "${{ inputs.is-production }}" \
+      --package-name "quilt-mcp-server"
 ```
 
 ## Content Format