Skip to content

Improve usability of @ConfigProperties #9348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 18, 2020
Merged

Improve usability of @ConfigProperties #9348

merged 4 commits into from
May 18, 2020

Conversation

@geoand
Copy link
Contributor

@geoand geoand commented May 15, 2020 •
edited
Loading

Introduces the following changes:

  • Ensure that static fields don't break classes annotated with @ConfigProperties
  • Give actionable warning when a parent class is not in the Jandex index
  • Add ability to ignore missing setters (useful for migration purposes)
  • Add support for enum values

cc @dejanb

@boring-cyborg boring-cyborg bot added the area/arc Issue related to ARC (dependency injection) label May 15, 2020
@geoand geoand requested a review from mkouba May 15, 2020 14:07
@geoand geoand added this to the 1.5.0 milestone May 15, 2020
@geoand geoand force-pushed the config-properties-usability branch from 2277852 to d24da0b Compare May 15, 2020 15:10
@geoand geoand mentioned this pull request May 15, 2020
Closed
@geoand geoand force-pushed the config-properties-usability branch 3 times, most recently from cd343de to 564090e Compare May 15, 2020 16:07
@geoand geoand marked this pull request as ready for review May 15, 2020 18:13
@geoand geoand force-pushed the config-properties-usability branch from 564090e to 1272aa0 Compare May 17, 2020 04:52
@gsmet gsmet merged commit 524b382 into quarkusio:master May 18, 2020
@geoand geoand deleted the config-properties-usability branch May 18, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gsmet gsmet gsmet approved these changes

@mkouba mkouba Awaiting requested review from mkouba

+1 more reviewer

@machi1990 machi1990 machi1990 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/arc Issue related to ARC (dependency injection)

Projects

None yet

Milestone

1.5.0.CR1

Development

Successfully merging this pull request may close these issues.

3 participants

@geoand @gsmet @machi1990