Skip to content

Ensure that @QuarkusTest plays nicely with @TestFactory #8012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Ensure that @QuarkusTest plays nicely with @TestFactory #8012

wants to merge 1 commit into from

Conversation

@geoand
Copy link
Contributor

@geoand geoand commented Mar 20, 2020 •
edited
Loading

Currently TestFactory can't be used with DynamicTest for 2 reasons:

  • The methods are not intercepted
  • The is no handling for the different CLs

This PR introduces the necessary interception and ClassLoader handling to get DynamicTest to work. However this requires user code to use QuarkusDynamicTest instead of JUnit's DynamicTest and to not return specify DynamicTest as the method signature (due to JUnit 5 expecting DynamicTest to be loaded from the regular CL).

Fixes: #8004

@geoand geoand requested review from gsmet and stuartwdouglas March 20, 2020 10:28
@geoand geoand mentioned this pull request Mar 20, 2020
Closed
@geoand geoand marked this pull request as ready for review March 20, 2020 11:39
@gastaldi gastaldi added this to the 1.4.0 milestone Mar 22, 2020
@geoand
Copy link
Contributor Author

geoand commented Mar 22, 2020

@stuartwdouglas what you do you think about this?
I can't say I'm excited about it, but I didn't come up with anything better unfortunately...

@stuartwdouglas
Copy link
Collaborator

Lets see if #8066 passes CI

@geoand
Copy link
Contributor Author

geoand commented Mar 23, 2020

Oh nice! I keep on forgetting about the parentFirst ClassLoader.

@geoand geoand closed this Mar 23, 2020
@gastaldi gastaldi deleted the #8004 branch March 23, 2020 12:31
@gsmet gsmet added triage/invalid This doesn't seem right and removed triage/backport? labels Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartwdouglas stuartwdouglas Awaiting requested review from stuartwdouglas

@gsmet gsmet Awaiting requested review from gsmet

Assignees

No one assigned

Labels

area/testing triage/invalid This doesn't seem right

Projects

None yet

Milestone

1.4.0.CR1

Development

Successfully merging this pull request may close these issues.

Regression: @Inject mock service in QuarkusTest is null during JUnit @TestFactory execution in Quarkus 1.3.0.Final

4 participants

@geoand @stuartwdouglas @gastaldi @gsmet