Allow beans to be injected in tests even if they aren't used in the app

Fixes: #1749

Author: geoand

core/deployment/src/main/java/io/quarkus/deployment/test/TestDefiningAnnotationBuildItemProvider.java

@@ -0,0 +1,29 @@
+package io.quarkus.deployment.test;
+
+import org.jboss.builder.BuildStep;
+import org.jboss.builder.item.BuildItem;
+import org.jboss.jandex.DotName;
+
+// this is only needed because the test modules do not depend on Arc
+public interface TestDefiningAnnotationBuildItemProvider {
+
+    Output customize(DotName dotName);
+
+    class Output {
+        private final BuildStep buildStep;
+        private final Class<? extends BuildItem> producer;
+
+        public Output(BuildStep buildStep, Class<? extends BuildItem> producer) {
+            this.buildStep = buildStep;
+            this.producer = producer;
+        }
+
+        public BuildStep getBuildStep() {
+            return buildStep;
+        }
+
+        public Class<? extends BuildItem> getProduces() {
+            return producer;
+        }
+    }
+}

extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/test/ArcTestDefiningAnnotationBuildItemProvider.java

@@ -0,0 +1,23 @@
+package io.quarkus.arc.deployment.test;
+
+import org.jboss.builder.BuildContext;
+import org.jboss.builder.BuildStep;
+import org.jboss.jandex.DotName;
+
+import io.quarkus.arc.deployment.BeanDefiningAnnotationBuildItem;
+import io.quarkus.deployment.test.TestDefiningAnnotationBuildItemProvider;
+
+public class ArcTestDefiningAnnotationBuildItemProvider implements TestDefiningAnnotationBuildItemProvider {
+
+    @Override
+    public Output customize(DotName dotName) {
+        return new Output(
+                new BuildStep() {
+                    @Override
+                    public void execute(BuildContext context) {
+                        context.produce(new BeanDefiningAnnotationBuildItem(dotName));
+                    }
+                },
+                BeanDefiningAnnotationBuildItem.class);
+    }
+}

extensions/arc/deployment/src/main/resources/META-INF/services/io.quarkus.deployment.test.TestDefiningAnnotationBuildItemProvider

@@ -0,0 +1 @@
+io.quarkus.arc.deployment.test.ArcTestDefiningAnnotationBuildItemProvider

integration-tests/main/src/main/java/io/quarkus/example/arc/UnusedBean.java

@@ -0,0 +1,7 @@
+package io.quarkus.example.arc;
+
+import javax.enterprise.context.ApplicationScoped;
+
+@ApplicationScoped
+public class UnusedBean {
+}

integration-tests/main/src/test/java/io/quarkus/example/test/BeanOnlyInTestCase.java

@@ -0,0 +1,22 @@
+package io.quarkus.example.test;
+
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+
+import javax.inject.Inject;
+
+import org.junit.jupiter.api.Test;
+
+import io.quarkus.example.arc.UnusedBean;
+import io.quarkus.test.junit.QuarkusTest;
+
+@QuarkusTest
+class BeanOnlyInTestCase {
+
+    @Inject
+    UnusedBean unusedBean;
+
+    @Test
+    void assertBeanIsInjected() {
+        assertNotNull(unusedBean);
+    }
+}

test-framework/common/src/main/java/io/quarkus/test/common/TestAnnotationAsBeanDefiningAnnotationUtil.java

@@ -0,0 +1,34 @@
+package io.quarkus.test.common;
+
+import java.util.ServiceLoader;
+import java.util.function.Consumer;
+
+import org.jboss.builder.BuildChainBuilder;
+import org.jboss.jandex.DotName;
+
+import io.quarkus.deployment.test.TestDefiningAnnotationBuildItemProvider;
+import io.quarkus.runner.RuntimeRunner;
+
+public final class TestAnnotationAsBeanDefiningAnnotationUtil {
+
+    private TestAnnotationAsBeanDefiningAnnotationUtil() {
+    }
+
+    public static void makeTestsBeanDefiningAnnotations(RuntimeRunner.Builder builder, Class testClass) {
+        // this elaborate construct is needed to make sure that if Arc is being used (even though the test module)
+        // does not depend on it, that QuarkusTest classes will be treaded as "beans", and therefore injection
+        // of beans into them is possible even those beans are not injected anywhere else
+        ServiceLoader<TestDefiningAnnotationBuildItemProvider> loader = ServiceLoader
+                .load(TestDefiningAnnotationBuildItemProvider.class);
+        for (TestDefiningAnnotationBuildItemProvider provider : loader) {
+            builder.addChainCustomizer(new Consumer<BuildChainBuilder>() {
+                @Override
+                public void accept(BuildChainBuilder buildChainBuilder) {
+                    final TestDefiningAnnotationBuildItemProvider.Output output = provider
+                            .customize(DotName.createSimple(testClass.getName()));
+                    buildChainBuilder.addBuildStep(output.getBuildStep()).produces(output.getProduces()).build();
+                }
+            });
+        }
+    }
+}

test-framework/junit5/src/main/java/io/quarkus/test/junit/QuarkusTestExtension.java

@@ -18,6 +18,7 @@
 
 import static io.quarkus.test.common.PathTestHelper.getAppClassLocation;
 import static io.quarkus.test.common.PathTestHelper.getTestClassesLocation;
+import static io.quarkus.test.common.TestAnnotationAsBeanDefiningAnnotationUtil.makeTestsBeanDefiningAnnotations;
 
 import java.io.Closeable;
 import java.io.FileOutputStream;
@@ -126,7 +127,7 @@ private ExtensionState doJavaStart(ExtensionContext context, TestResourceManager
         }
         originalCl = setCCL(appCl);
 
-        RuntimeRunner runtimeRunner = RuntimeRunner.builder()
+        final RuntimeRunner.Builder builder = RuntimeRunner.builder()
                 .setLaunchMode(LaunchMode.TEST)
                 .setClassLoader(appCl)
                 .setTarget(appClassLocation)
@@ -242,8 +243,11 @@ public boolean test(String className) {
                         }).produces(TestClassPredicateBuildItem.class)
                                 .build();
                     }
-                })
-                .build();
+                });
+
+        makeTestsBeanDefiningAnnotations(builder, QuarkusTest.class);
+
+        RuntimeRunner runtimeRunner = builder.build();
         runtimeRunner.run();
 
         Closeable shutdownTask = new Closeable() {