Improve getResources performance

Author: stuartwdouglas

independent-projects/bootstrap/core/src/main/java/io/quarkus/bootstrap/classloading/JarClassPathElement.java

@@ -129,7 +129,11 @@ public Set<String> apply(JarFile jarFile) {
                 Enumeration<JarEntry> entries = jarFile.entries();
                 while (entries.hasMoreElements()) {
                     JarEntry entry = entries.nextElement();
-                    paths.add(entry.getName());
+                    if (entry.getName().endsWith("/")) {
+                        paths.add(entry.getName().substring(0, entry.getName().length() - 1));
+                    } else {
+                        paths.add(entry.getName());
+                    }
                 }
                 return paths;
             }

independent-projects/bootstrap/core/src/main/java/io/quarkus/bootstrap/classloading/QuarkusClassLoader.java

@@ -152,12 +152,6 @@ public Enumeration<URL> getResources(String nm) throws IOException {
         //for single resources we still respect this
         boolean banned = state.bannedResources.contains(name);
         Set<URL> resources = new LinkedHashSet<>();
-        //ClassPathElement[] providers = loadableResources.get(name);
-        //if (providers != null) {
-        //    for (ClassPathElement element : providers) {
-        //        resources.add(element.getResource(nm).getUrl());
-        //    }
-        //}
 
         //this is a big of a hack, but is necessary to prevent service leakage
         //in some situations (looking at you gradle) the parent can contain the same
@@ -179,10 +173,12 @@ public Enumeration<URL> getResources(String nm) throws IOException {
                 //ignore
             }
         }
-        for (ClassPathElement i : elements) {
-            ClassPathResource res = i.getResource(nm);
-            if (res != null) {
-                resources.add(res.getUrl());
+        //TODO: in theory resources could have been added in dev mode
+        //but I don't thing this really matters for this code path
+        ClassPathElement[] providers = state.loadableResources.get(name);
+        if (providers != null) {
+            for (ClassPathElement element : providers) {
+                resources.add(element.getResource(nm).getUrl());
             }
         }
         if (!banned) {
@@ -259,15 +255,20 @@ public URL getResource(String nm) {
         if (state.bannedResources.contains(name)) {
             return null;
         }
-        //        ClassPathElement[] providers = loadableResources.get(name);
-        //        if (providers != null) {
-        //            return providers[0].getResource(nm).getUrl();
-        //        }
-        //TODO: because of dev mode we can't use the fast path her, we need to iterate
-        for (ClassPathElement i : elements) {
-            ClassPathResource res = i.getResource(name);
-            if (res != null) {
-                return res.getUrl();
+        //TODO: because of dev mode we iterate, to see if any resources were added
+        //not for .class files though, adding them causes a restart
+        //this is very important for bytebuddy performance
+        if (nm.endsWith(".class")) {
+            ClassPathElement[] providers = state.loadableResources.get(name);
+            if (providers != null) {
+                return providers[0].getResource(nm).getUrl();
+            }
+        } else {
+            for (ClassPathElement i : elements) {
+                ClassPathResource res = i.getResource(name);
+                if (res != null) {
+                    return res.getUrl();
+                }
             }
         }
         return parent.getResource(nm);
@@ -280,15 +281,18 @@ public InputStream getResourceAsStream(String nm) {
         if (state.bannedResources.contains(name)) {
             return null;
         }
-        //        ClassPathElement[] providers = loadableResources.get(name);
-        //        if (providers != null) {
-        //            return new ByteArrayInputStream(providers[0].getResource(nm).getData());
-        //        }
-        //TODO: because of dev mode we can't use the fast path her, we need to iterate
-        for (ClassPathElement i : elements) {
-            ClassPathResource res = i.getResource(name);
-            if (res != null) {
-                return new ByteArrayInputStream(res.getData());
+        //dev mode may have added some files, so we iterate to check, but not for classes
+        if (nm.endsWith(".class")) {
+            ClassPathElement[] providers = state.loadableResources.get(name);
+            if (providers != null) {
+                return new ByteArrayInputStream(providers[0].getResource(nm).getData());
+            }
+        } else {
+            for (ClassPathElement i : elements) {
+                ClassPathResource res = i.getResource(name);
+                if (res != null) {
+                    return new ByteArrayInputStream(res.getData());
+                }
             }
         }
         return parent.getResourceAsStream(nm);