Merge pull request #9358 from mkouba/reactive-route-cache-sec-identity-event

Reactive routes security - use shared Event instance

Author: mkouba

extensions/vertx-web/deployment/src/main/java/io/quarkus/vertx/web/deployment/VertxWebProcessor.java

@@ -59,6 +59,7 @@
 import io.quarkus.deployment.annotations.Record;
 import io.quarkus.deployment.builditem.FeatureBuildItem;
 import io.quarkus.deployment.builditem.GeneratedClassBuildItem;
+import io.quarkus.deployment.builditem.ShutdownContextBuildItem;
 import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
 import io.quarkus.deployment.util.HashUtil;
 import io.quarkus.gizmo.AssignableResultHandle;
@@ -211,7 +212,8 @@ void addAdditionalRoutes(
             BuildProducer<RouteBuildItem> routeProducer,
             BuildProducer<FilterBuildItem> filterProducer,
             List<RequireBodyHandlerBuildItem> bodyHandlerRequired,
-            BeanArchiveIndexBuildItem beanArchive) throws IOException {
+            BeanArchiveIndexBuildItem beanArchive,
+            ShutdownContextBuildItem shutdown) throws IOException {
 
         ClassOutput classOutput = new GeneratedClassGizmoAdaptor(generatedClass, true);
         IndexView index = beanArchive.getIndex();
@@ -326,6 +328,8 @@ void addAdditionalRoutes(
         }
 
         detectConflictingRoutes(matchers);
+
+        recorder.clearCacheOnShutdown(shutdown);
     }
 
     @BuildStep

extensions/vertx-web/runtime/src/main/java/io/quarkus/vertx/web/runtime/RouteHandler.java

@@ -28,14 +28,14 @@ default void handle(RoutingContext context) {
         //todo: how should we handle non-proactive authentication here?
         if (requestContext.isActive()) {
             if (user != null) {
-                Arc.container().beanManager().fireEvent(user.getSecurityIdentity());
+                RouteHandlers.fireSecurityIdentity(user.getSecurityIdentity());
             }
             invoke(context);
         } else {
             try {
                 requestContext.activate();
                 if (user != null) {
-                    Arc.container().beanManager().fireEvent(user.getSecurityIdentity());
+                    RouteHandlers.fireSecurityIdentity(user.getSecurityIdentity());
                 }
                 invoke(context);
             } finally {

extensions/vertx-web/runtime/src/main/java/io/quarkus/vertx/web/runtime/RouteHandlers.java

@@ -0,0 +1,26 @@
+package io.quarkus.vertx.web.runtime;
+
+import javax.enterprise.event.Event;
+
+import io.quarkus.arc.Arc;
+import io.quarkus.arc.impl.LazyValue;
+import io.quarkus.security.identity.SecurityIdentity;
+
+final class RouteHandlers {
+
+    private static final LazyValue<Event<SecurityIdentity>> SECURITY_IDENTITY_EVENT = new LazyValue<>(
+            RouteHandlers::createEvent);
+
+    static void fireSecurityIdentity(SecurityIdentity identity) {
+        SECURITY_IDENTITY_EVENT.get().fire(identity);
+    }
+
+    static void clear() {
+        SECURITY_IDENTITY_EVENT.clear();
+    }
+
+    private static Event<SecurityIdentity> createEvent() {
+        return Arc.container().beanManager().getEvent().select(SecurityIdentity.class);
+    }
+
+}

extensions/vertx-web/runtime/src/main/java/io/quarkus/vertx/web/runtime/VertxWebRecorder.java

@@ -3,6 +3,7 @@
 import java.lang.reflect.InvocationTargetException;
 import java.util.function.Function;
 
+import io.quarkus.runtime.ShutdownContext;
 import io.quarkus.runtime.annotations.Recorder;
 import io.quarkus.vertx.http.runtime.RouterProducer;
 import io.vertx.core.Handler;
@@ -69,4 +70,13 @@ public io.vertx.ext.web.Route apply(Router router) {
         };
     }
 
+    public void clearCacheOnShutdown(ShutdownContext shutdown) {
+        shutdown.addShutdownTask(new Runnable() {
+            @Override
+            public void run() {
+                RouteHandlers.clear();
+            }
+        });
+    }
+
 }

independent-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/BeanManagerImpl.java

@@ -121,7 +121,9 @@ public void validate(InjectionPoint injectionPoint) {
 
     @Override
     public void fireEvent(Object event, Annotation... qualifiers) {
-        getEvent().select(qualifiers).fire(event);
+        Set<Annotation> eventQualifiers = new HashSet<>();
+        Collections.addAll(eventQualifiers, qualifiers);
+        new EventImpl<Object>(event.getClass(), eventQualifiers).fire(event);
     }
 
     @Override