Merge pull request #8844 from stuartwdouglas/stable-recorder-names

Generate stable names for recorded bytecode

Author: gsmet

core/deployment/src/main/java/io/quarkus/deployment/ExtensionLoader.java

@@ -921,7 +921,8 @@ public void execute(final BuildContext bc) {
                                 Object[] methodArgs = new Object[methodParamFns.size()];
                                 BytecodeRecorderImpl bri = isRecorder
                                         ? new BytecodeRecorderImpl(recordAnnotation.value() == ExecutionTime.STATIC_INIT,
-                                                clazz.getSimpleName(), method.getName())
+                                                clazz.getSimpleName(), method.getName(),
+                                                Integer.toString(method.toString().hashCode()))
                                         : null;
                                 for (int i = 0; i < methodArgs.length; i++) {
                                     methodArgs[i] = methodParamFns.get(i).apply(bc, bri);

core/deployment/src/main/java/io/quarkus/deployment/recording/BytecodeRecorderImpl.java

@@ -88,7 +88,6 @@ public class BytecodeRecorderImpl implements RecorderContext {
     private static final Class<?> SINGLETON_MAP_CLASS = Collections.singletonMap(1, 1).getClass();
 
     private static final AtomicInteger COUNT = new AtomicInteger();
-    private static final AtomicInteger OUTPUT_COUNT = new AtomicInteger();
     private static final String BASE_PACKAGE = "io.quarkus.deployment.steps.";
 
     private static final String PROXY_KEY = "proxykey";
@@ -128,9 +127,9 @@ public BytecodeRecorderImpl(ClassLoader classLoader, boolean staticInit, String
         this.className = className;
     }
 
-    public BytecodeRecorderImpl(boolean staticInit, String buildStepName, String methodName) {
+    public BytecodeRecorderImpl(boolean staticInit, String buildStepName, String methodName, String uniqueHash) {
         this(Thread.currentThread().getContextClassLoader(), staticInit,
-                BASE_PACKAGE + buildStepName + "$" + methodName + OUTPUT_COUNT.incrementAndGet());
+                BASE_PACKAGE + buildStepName + "$" + methodName + uniqueHash);
     }
 
     public boolean isEmpty() {