Skip to content

Commit a0c7775

Browse files
committed
Log a warning when an export fails for http/protobuf
This is exactly the same as with grpc Fixes: #48572
1 parent 765160e commit a0c7775

File tree

2 files changed

+22
-11
lines changed

2 files changed

+22
-11
lines changed

extensions/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/exporter/otlp/sender/VertxGrpcSender.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ public void accept(GrpcClientRequest<Buffer, Buffer> request) {
179179
private void failOnClientRequest(String type, Throwable t, Consumer<Throwable> onError) {
180180
String message = "Failed to export "
181181
+ type
182-
+ "s. The request could not be executed. Full error message: "
182+
+ ". The request could not be executed. Full error message: "
183183
+ (t.getMessage() == null ? t.getClass().getName() : t.getMessage());
184184
logger.log(Level.WARNING, message);
185185
onError.accept(t);

extensions/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/exporter/otlp/sender/VertxHttpSender.java

Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -101,19 +101,33 @@ public void send(Marshaler marshaler,
101101
return;
102102
}
103103

104+
String marshalerType = marshaler.getClass().getSimpleName();
104105
String requestURI = basePath + signalPath;
105106
var clientRequestSuccessHandler = new ClientRequestSuccessHandler(client, requestURI, headers, compressionEnabled,
106107
contentType,
107108
contentLength, onHttpResponseRead,
108109
onError, marshaler, 1, isShutdown::get);
109-
initiateSend(client, requestURI, MAX_ATTEMPTS, clientRequestSuccessHandler, onError, isShutdown::get);
110+
initiateSend(client, requestURI, MAX_ATTEMPTS, clientRequestSuccessHandler, new Consumer<>() {
111+
@Override
112+
public void accept(Throwable throwable) {
113+
failOnClientRequest(marshalerType, throwable, onError);
114+
}
115+
});
116+
}
117+
118+
private void failOnClientRequest(String type, Throwable t, Consumer<Throwable> onError) {
119+
String message = "Failed to export "
120+
+ type
121+
+ ". The request could not be executed. Full error message: "
122+
+ (t.getMessage() == null ? t.getClass().getName() : t.getMessage());
123+
logger.log(Level.WARNING, message);
124+
onError.accept(t);
110125
}
111126

112127
private static void initiateSend(HttpClient client, String requestURI,
113128
int numberOfAttempts,
114129
Handler<HttpClientRequest> clientRequestSuccessHandler,
115-
Consumer<Throwable> onError,
116-
Supplier<Boolean> isShutdown) {
130+
Consumer<Throwable> onFailureCallback) {
117131
Uni.createFrom().completionStage(new Supplier<CompletionStage<HttpClientRequest>>() {
118132
@Override
119133
public CompletionStage<HttpClientRequest> get() {
@@ -144,7 +158,7 @@ public Uni<? extends HttpClientRequest> get() {
144158
public void accept(HttpClientRequest request) {
145159
clientRequestSuccessHandler.handle(request);
146160
}
147-
}, onError);
161+
}, onFailureCallback);
148162
}
149163

150164
@Override
@@ -234,8 +248,7 @@ public void handle(AsyncResult<Buffer> bodyResult) {
234248
initiateSend(client, requestURI,
235249
MAX_ATTEMPTS - attemptNumber,
236250
newAttempt(),
237-
onError,
238-
isShutdown);
251+
onError);
239252
return;
240253
}
241254
}
@@ -261,8 +274,7 @@ public byte[] responseBody() {
261274
initiateSend(client, requestURI,
262275
MAX_ATTEMPTS - attemptNumber,
263276
newAttempt(),
264-
onError,
265-
isShutdown);
277+
onError);
266278
} else {
267279
onError.accept(bodyResult.cause());
268280
}
@@ -275,8 +287,7 @@ public byte[] responseBody() {
275287
initiateSend(client, requestURI,
276288
MAX_ATTEMPTS - attemptNumber,
277289
newAttempt(),
278-
onError,
279-
isShutdown);
290+
onError);
280291
} else {
281292
onError.accept(callResult.cause());
282293
}

0 commit comments

Comments
 (0)