Skip to content

Commit 8f86809

Browse files
authored
Change filter button focus and fix issue (#1682)
1 parent 6fb81e1 commit 8f86809

File tree

9 files changed

+18
-12
lines changed

9 files changed

+18
-12
lines changed

base/src/main/resources/web/lib/components/extensions-picker/extension-search-bar.scss

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,11 @@
5858
gap: 5px;
5959
background-color: var(--extensionsPickerSearchBg);
6060

61+
62+
@media screen and (max-width: $mobileWidth) {
63+
margin: 0 10px;
64+
}
65+
6166
.search-icon {
6267
flex-basis: 40px;
6368
height: 100%;
@@ -100,6 +105,7 @@
100105
&:focus {
101106
outline: none;
102107
}
108+
103109
}
104110

105111
.filters-bar {
@@ -120,7 +126,7 @@
120126

121127
.filters {
122128
display: flex;
123-
129+
gap: 3px;
124130

125131
@media screen and (max-width: $mobileWidth) {
126132
display: none;
@@ -164,9 +170,10 @@
164170
text-transform: capitalize;
165171
margin: 0;
166172
padding: 0px 20px;
173+
border: 1px solid transparent;
167174

168175
&[aria-expanded="true"], &:hover {
169-
background-color: var(--extensionsPickerSearchBorderColorOnFocus);
176+
border-color: var(--extensionsPickerSearchBorderColorOnFocus);
170177
}
171178
}
172179

base/src/main/resources/web/lib/components/extensions-picker/extension-search-bar.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import React from 'react';
22
import {Button, Form, FormGroup} from 'react-bootstrap';
3-
import {FaSearch, FaTimes, FaCaretUp, FaCaretDown} from 'react-icons/fa';
3+
import {FaSearch, FaCaretUp, FaCaretDown} from 'react-icons/fa';
4+
import {FaRegCircleXmark} from 'react-icons/fa6';
45
import {QuarkusProject} from '../api/model';
56
import './extension-search-bar.scss';
67
import {
@@ -114,7 +115,7 @@ export function ExtensionSearchBar(props: ExtensionSearchBarProps) {
114115
onChange={search}
115116
/>
116117
{!isFilterEmpty(filter) &&
117-
<Button as="a" className='clear-button' onClick={clearFilters} aria-label="Clear filters"><FaTimes/><span>Clear filters</span></Button>
118+
<Button as="a" className='clear-button' onClick={clearFilters} aria-label="Clear filters"><FaRegCircleXmark/><span>Clear filters</span></Button>
118119
}
119120

120121
</FormGroup>

base/src/main/resources/web/lib/components/extensions-picker/extensions-utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ export function clearMetadataFilter(query: string, key: string) {
272272
}
273273

274274
export function addExcludeMetadataFilter(query: string, key: string) {
275-
return `!${key}` + query.replace(new RegExp(`${key}:\\S+`), '').trim();
275+
return `!${key} ` + query.replace(new RegExp(`${key}:\\S+`), '').trim();
276276
}
277277

278278
export function addStarMetadataFilter(query: string, key: string) {

base/src/main/resources/web/lib/components/header/code-quarkus-header.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
}
6666

6767
@media screen and (max-width: $mobileWidth) {
68-
margin-left: 20px;
68+
margin-left: 10px;
6969
img {
7070
height: 20px;
7171
}

base/src/main/resources/web/lib/components/quarkus-project/quarkus-project-edition-form.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
padding-bottom: 30px;
55

66
@media screen and (max-width: $mobileWidth) {
7-
margin: 0 10px;
7+
margin: 0;
88
}
99

1010
.form-header-sticky-container {

base/src/test/resources/__snapshots__/QuarkusProjectServiceTest/test3__15/dir-tree.snapshot

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
.gitignore
33
.mvn/
44
.mvn/wrapper/
5-
.mvn/wrapper/.gitignore
6-
.mvn/wrapper/MavenWrapperDownloader.java
75
.mvn/wrapper/maven-wrapper.properties
86
/
97
README.md

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
<quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id>
1919
<quarkus.platform.group-id>io.quarkus.platform</quarkus.platform.group-id>
20-
<quarkus.platform.version>3.26.4</quarkus.platform.version>
20+
<quarkus.platform.version>3.28.1</quarkus.platform.version>
2121

2222
<skipITs>true</skipITs>
2323
<surefire-plugin.version>3.5.4</surefire-plugin.version>

web-deps/locker/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -957,7 +957,7 @@
957957
<dependency>
958958
<groupId>org.mvnpm</groupId>
959959
<artifactId>react-icons</artifactId>
960-
<version>5.1.0</version>
960+
<version>5.5.0</version>
961961
</dependency>
962962
<dependency>
963963
<groupId>org.mvnpm</groupId>

web-deps/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
<dependency>
7878
<groupId>org.mvnpm</groupId>
7979
<artifactId>react-icons</artifactId>
80-
<version>5.1.0</version>
80+
<version>5.5.0</version>
8181
</dependency>
8282
<dependency>
8383
<groupId>org.mvnpm</groupId>

0 commit comments

Comments
 (0)