Skip to content

Commit 80e6fc4

Browse files
authored
Make extension icon part of the theme (#1665)
1 parent b3c5bc1 commit 80e6fc4

File tree

9 files changed

+21
-15
lines changed

9 files changed

+21
-15
lines changed

.github/quarkus-ecosystem-test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/usr/bin/env bash
22
set -e
33

4-
mvn exec:java -e -D exec.mainClass=com.microsoft.playwright.CLI -D exec.args="install-deps chromium"
4+
mvn exec:java -e -D exec.mainClass=com.microsoft.playwright.CLI -D exec.args="install chromium --with-deps"
55

66
## Testing using quarkus snapshot + no real platform; just core. Will thus not find platform issues; but will
77
## find core vs code.quarkus issues.

.github/workflows/build.actions.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
path: ~/.m2/repository
3131
key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
3232
- name: Ensure browsers are installed
33-
run: mvn exec:java -e -D exec.mainClass=com.microsoft.playwright.CLI -D exec.args="install --with-deps"
33+
run: mvn exec:java -e -D exec.mainClass=com.microsoft.playwright.CLI -D exec.args="install chromium --with-deps"
3434
- name: Build
3535
run: |
3636
mvn -e -B -DskipTests=true clean package -Dlib -Dacceptance-test -Dcommunity-app

.github/workflows/release.actions.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
git config --local user.name "GitHub Action"
6666
6767
- name: Ensure browsers are installed
68-
run: mvn exec:java -e -D exec.mainClass=com.microsoft.playwright.CLI -D exec.args="install-deps chromium"
68+
run: mvn exec:java -e -D exec.mainClass=com.microsoft.playwright.CLI -D exec.args="install chromium --with-deps"
6969

7070
- name: Maven release ${{steps.metadata.outputs.current-version}}
7171
if: steps.check_changes.outputs.skip == 'false'

base/src/main/resources/web/community-app/theme.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,8 @@
119119
--clearSelectedExtensionButtonBorderColor: var(--warningColor);
120120
--clearSelectedExtensionButtonTextColor: var(--mainContainerTextColor);
121121

122+
--extensionIconSvg: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' fill='white' viewBox='0 0 512 512'%3E%3C!--!Font Awesome Free v7.0.1 by @fontawesome - https://fontawesome.com License - https://fontawesome.com/license/free Copyright 2025 Fonticons, Inc.--%3E%3Cpath opacity='.4' d='M-2.9 271.5C-15.7 292.9-.3 320 24.5 320L128 320c14.2-67.4 34.3-119.7 58.1-160l-95 0c-16.9 0-32.5 8.8-41.2 23.3L-2.9 271.5zM192 384l0 103.5c0 24.9 27.1 40.2 48.5 27.4L328.7 462c14.5-8.7 23.3-24.3 23.3-41.2l0-95c-40.3 23.8-92.6 43.9-160 58.1z'/%3E%3Cpath d='M128 320c59.6-283.1 224-298.9 323.6-284.3 12.8 1.9 22.8 11.9 24.6 24.6 14.6 99.6-1.2 264-284.3 323.6 0-35.3-28.7-64-64-64zM400 160a48 48 0 1 0 -96 0 48 48 0 1 0 96 0z'/%3E%3C/svg%3E");
123+
122124
// Presets
123125
--presetsPanelBg: var(--extensionsPickerListBg);
124126
--presetsTitleTextColor: var(--mainContainerTextColor);

base/src/main/resources/web/lib/components/code-quarkus.scss

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,14 @@ code {
1919
text-transform: var(--mainTitleTextTransform) !important;
2020
}
2121

22+
.extension-icon {
23+
background-image: var(--extensionIconSvg);
24+
background-repeat: no-repeat;
25+
display: inline-block;
26+
width: 16px;
27+
height: 16px;
28+
}
29+
2230
.responsive-container {
2331
max-width: 1200px;
2432

base/src/main/resources/web/lib/components/extensions-picker/presets-panel.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import styled from 'styled-components';
22
import {TagEntry} from "./extensions-picker";
33
import {Platform, Preset} from "../api/model";
4-
import {FaRocket} from 'react-icons/fa';
54

65
import {useAnalytics} from "../../core/analytics";
76

@@ -24,8 +23,8 @@ const PresetsPanelDiv = styled.div`
2423
background-color: var(--presetsPanelBg);
2524
color: var(--presetsTitleTextColor);
2625
27-
svg {
28-
margin-right: 5px;
26+
.extension-icon {
27+
margin-right: 3px;
2928
}
3029
}
3130
@@ -89,7 +88,7 @@ export const PresetsPanel = (props: PresetsProps) => {
8988
};
9089
return (
9190
<PresetsPanelDiv className="presets-panel">
92-
<div className="panel-title main-title"><FaRocket />&nbsp;Start with a preset of extensions</div>
91+
<div className="panel-title main-title"><span className="extension-icon"></span>&nbsp;Start with a preset of extensions</div>
9392
<div className="presets-list">
9493
{presets.map(p => (
9594
<PresetCard key={p.key} preset={p} onClick={() => selectPreset(p)}/>

base/src/main/resources/web/lib/components/generate-project/extensions-cart.scss

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,16 @@
66
background-color: var(--extensionsCartButtonBgColor);
77
color: var(--extensionsCartButtonTextColor);
88
width: 50px;
9-
text-align: center;
10-
line-height: 40px;
119
font-weight: bold;
1210
padding: 0;
1311
border: none;
1412
cursor: pointer;
13+
display: flex;
14+
align-items: center;
15+
justify-content: center;
1516

16-
svg {
17+
.extension-icon {
1718
margin-right: 5px;
18-
height: 40px;
19-
vertical-align: top;
2019
}
2120
}
2221

base/src/main/resources/web/lib/components/generate-project/extensions-cart.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import React, {useEffect, useState} from 'react';
22
import './extensions-cart.scss';
3-
import {FaRocket} from 'react-icons/fa';
43
import {Button, ButtonGroup, Dropdown} from 'react-bootstrap';
54
import DropdownToggle from 'react-bootstrap/DropdownToggle';
65
import {ExtensionEntry, TagEntry} from '../extensions-picker/extensions-picker';
@@ -50,7 +49,7 @@ export function ExtensionsCart(props: ExtensionsCartProps) {
5049
show={isOpen || openedFromChange} onMouseLeave={onMouseLeaveFn}>
5150
<DropdownToggle as={Button} aria-label="Selected extensions" className="extensions-cart-button"
5251
onMouseEnter={onMouseEnterFn}>
53-
<FaRocket/>
52+
<span className="extension-icon"></span>
5453
{props.value.extensions.length}
5554
</DropdownToggle>
5655

base/src/main/resources/web/lib/components/generate-project/generate-button.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
text-align: center;
2424
border: 2px solid var(--generateButtonBgColor);
2525
color: var(--generateButtonTextColor);
26-
font-weight: bold;
2726

2827
&:hover {
2928
border: 2px solid var(--generateButtonBorderColorOnHover);

0 commit comments

Comments
 (0)