Fixed #50 #49 #48, a divide by 0 operation causes NaN

wgliang · wgliang · commit 05bf51bd9177 · 2017-11-22T11:03:49.000+08:00
diff --git a/engine/report2html.go b/engine/report2html.go
@@ -111,7 +111,11 @@ func (hd *HtmlData) converterCodeTest(structData Reporter) {
 		}
 		codeTestHtmlData.Summary.TotalTime, _ = strconv.ParseFloat(strconv.FormatFloat(totalTime, 'f', 1, 64), 64)
 		codeTestHtmlData.Summary.CodeCover, _ = strconv.ParseFloat(strconv.FormatFloat(result.Percentage, 'f', 1, 64), 64)
-		codeTestHtmlData.Summary.PackageCover, _ = strconv.ParseFloat(strconv.FormatFloat(100*float64(len(codeTestHtmlData.Content.Pkg))*1.0/float64(len(codeTestHtmlData.Content.Pkg)+len(codeTestHtmlData.Content.NoTest)), 'f', 1, 64), 64)
+		if (len(codeTestHtmlData.Content.Pkg) + len(codeTestHtmlData.Content.NoTest)) == 0 {
+			codeTestHtmlData.Summary.PackageCover = 0
+		} else {
+			codeTestHtmlData.Summary.PackageCover, _ = strconv.ParseFloat(strconv.FormatFloat(100*float64(len(codeTestHtmlData.Content.Pkg))*1.0/float64(len(codeTestHtmlData.Content.Pkg)+len(codeTestHtmlData.Content.NoTest)), 'f', 1, 64), 64)
+		}
 	}
 
 	stringCodeTestJson, err := jsoniter.Marshal(codeTestHtmlData)

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,11 @@ func (hd *HtmlData) converterCodeTest(structData Reporter) {`
`111`	`111`	`}`
`112`	`112`	`codeTestHtmlData.Summary.TotalTime, _ = strconv.ParseFloat(strconv.FormatFloat(totalTime, 'f', 1, 64), 64)`
`113`	`113`	`codeTestHtmlData.Summary.CodeCover, _ = strconv.ParseFloat(strconv.FormatFloat(result.Percentage, 'f', 1, 64), 64)`
`114`		`- codeTestHtmlData.Summary.PackageCover, _ = strconv.ParseFloat(strconv.FormatFloat(100float64(len(codeTestHtmlData.Content.Pkg))1.0/float64(len(codeTestHtmlData.Content.Pkg)+len(codeTestHtmlData.Content.NoTest)), 'f', 1, 64), 64)`
	`114`	`+ if (len(codeTestHtmlData.Content.Pkg) + len(codeTestHtmlData.Content.NoTest)) == 0 {`
	`115`	`+ codeTestHtmlData.Summary.PackageCover = 0`
	`116`	`+ } else {`
	`117`	`+ codeTestHtmlData.Summary.PackageCover, _ = strconv.ParseFloat(strconv.FormatFloat(100float64(len(codeTestHtmlData.Content.Pkg))1.0/float64(len(codeTestHtmlData.Content.Pkg)+len(codeTestHtmlData.Content.NoTest)), 'f', 1, 64), 64)`
	`118`	`+ }`
`115`	`119`	`}`
`116`	`120`
`117`	`121`	`stringCodeTestJson, err := jsoniter.Marshal(codeTestHtmlData)`