Bot

Author: qarmin

Changelog.md

@@ -1,7 +1,6 @@
 ## Version ?.?.? - ?
 ### Release blockers:
 - Missing support for hardlinking/softlinking files in Krokiet
-- Slint bug with selecting items with both mouse and keyboard -  https://github.com/slint-ui/slint/issues/9103
 - Unnecessary tokio dependency in rawler
 
 ### Breaking changes

justfile

@@ -28,6 +28,13 @@ runs +args:
     export ASAN_OPTIONS="symbolize=1:detect_leaks=0" # Leak check is disabled, because is slow and ususally not needed
     ASAN_OPTIONS="symbolize=1:detect_leaks=0" RUSTFLAGS="-Zsanitizer=address" cargo +nightly run --target x86_64-unknown-linux-gnu --bin {{args}}
 
+val bin:
+    valgrind --leak-check=full --show-leak-kinds=definite --track-origins=yes target/debug/{{bin}}
+
+valr bin:
+    valgrind --leak-check=full --show-leak-kinds=definite --track-origins=yes target/release/{{bin}}
+
+
 ## Other
 
 setup_sanitizer:

krokiet/ui/bottom_panel.slint

@@ -23,7 +23,6 @@ component DirectoriesPanel inherits HorizontalLayout {
     VerticalLayout {
         horizontal-stretch: 1.0;
         padding-top: 5px;
-        padding-bottom: 5px;
         HorizontalLayout {
             Button {
                 icon: @image-url("../icons/krokiet_add.svg");

krokiet/ui/selectable_tree_view.slint

@@ -110,15 +110,17 @@ export component SelectableTableView inherits Rectangle {
                 }
 
                 HorizontalLayout {
+                    // Workaround for https://github.com/slint-ui/slint/issues/602
+                    // Alternative solution is to use TouchArea above, to steal clicks from checkbox, but it is more fishy solution
                     CheckBox {
+                        property <bool> from_model: r.checked;
                         visible: !r.header_row;
                         checked: r.checked && !r.header_row;
                         width: root.column_sizes[0];
+                        changed from-model => { self.checked = from-model; }
                         toggled => {
                             Callabler.change_number_of_checked_items(r.checked ? -1 : 1);
-                            r.checked = !r.checked; 
-                            // TODO - this is equivalent to r.checked = self.checked, but for now it works better, because self.checked contains sometimes old state
-                            // https://github.com/slint-ui/slint/issues/602
+                            r.checked = !r.checked;
                         }
                     }
 

krokiet/ui/settings.slint

@@ -8,9 +8,9 @@ export global Settings {
     in-out property <int> language_index: 0;
     in-out property <string> language_value: "English";
 
-    in-out property <[IncludedDirectoriesModel]> included_directories_model: [{ path: "/home/path", referenced_folder: false, selected_row: false }];
+    in-out property <[IncludedDirectoriesModel]> included_directories_model: [{ path: "/home/path", referenced_folder: false, selected_row: false },{ path: "/home/path", referenced_folder: false, selected_row: false },{ path: "/home/path", referenced_folder: false, selected_row: false },{ path: "/home/path", referenced_folder: false, selected_row: false }];
     in-out property <int> included_directories_model_selected_idx: -1;
-    in-out property <[ExcludedDirectoriesModel]> excluded_directories_model: [{ path:"/home/path", selected_row: false }, { path:"/home/a", selected_row: false }];
+    in-out property <[ExcludedDirectoriesModel]> excluded_directories_model: [{ path:"/home/path", selected_row: false },{ path:"/home/path", selected_row: false },{ path:"/home/path", selected_row: false },{ path:"/home/path", selected_row: false }, { path:"/home/a", selected_row: false }];
     in-out property <int> excluded_directories_model_selected_idx: -1;
 
     // Settings