REA

Author: qarmin

README.md

@@ -141,6 +141,14 @@ articles about it etc.
 Also, I really appreciate work of people that create crates on which Czkawka is based and for that I try to report bugs
 to make it even better.
 
+## Officially Supported Projects
+Only the [prebuild-binaries](https://github.com/qarmin/czkawka/releases), projects on [crates.io](https://crates.io/crates/czkawka_gui) and [flathub](https://flathub.org/apps/com.github.qarmin.czkawka) are directly maintained by me.  
+
+Czkawka does not have an official website, so do not trust any sites that claim to be the official one.  
+
+If you use packages from unofficial sources, make sure they are safe.
+ 
+
 ## License
 
 The entire code in this repository is licensed under the [MIT](https://mit-license.org/) license.

krokiet/src/connect_row_selection.rs

@@ -211,6 +211,7 @@ mod opener {
 }
 mod selection {
     use super::*;
+    use crate::connect_row_selection::checker::change_number_of_enabled_items;
 
     pub(crate) fn connect_select_all_rows(app: &MainWindow) {
         let a = app.as_weak();
@@ -262,10 +263,11 @@ mod selection {
             let selection = lock.get_mut(&active_tab).expect("Failed to get selection data");
             let model = active_tab.get_tool_model(&app);
 
-            let new_model = rows_reverse_checked_selection(selection, &model);
+            let (checked_items, unchecked_items, new_model) = rows_reverse_checked_selection(selection, &model);
             if let Some(new_model) = new_model {
                 active_tab.set_tool_model(&app, new_model);
             }
+            change_number_of_enabled_items(&app, active_tab, checked_items as i64 - unchecked_items as i64);
         });
     }
     pub(crate) fn reverse_selection_on_specific_item(app: &MainWindow) {
@@ -317,6 +319,7 @@ pub(crate) mod checker {
         });
     }
 
+    // TODO - sad day for code readability, because slint not supports i64 - https://github.com/slint-ui/slint/issues/6589
     pub(crate) fn set_number_of_enabled_items(app: &MainWindow, active_tab: CurrentTab, items_number: u64) {
         let (it1, it2) = split_u64_into_i32s(items_number);
         error!("SET {:?}, {}", &active_tab, &items_number);
@@ -661,7 +664,9 @@ fn row_select_items_with_shift(selection: &mut SelectionData, model: &ModelRc<Ma
     }
 }
 
-fn rows_reverse_checked_selection(selection: &SelectionData, model: &ModelRc<MainListModel>) -> Option<ModelRc<MainListModel>> {
+fn rows_reverse_checked_selection(selection: &SelectionData, model: &ModelRc<MainListModel>) -> (u64, u64, Option<ModelRc<MainListModel>>) {
+    let (mut checked_items, mut unchecked_items) = (0, 0);
+
     if selection.exceeded_limit {
         trace!("[SLOW][REPLACE_MODEL] reverse checked selection(SPACE)");
         let new_model = model
@@ -670,11 +675,16 @@ fn rows_reverse_checked_selection(selection: &SelectionData, model: &ModelRc<Mai
                 if row.selected_row {
                     assert!(!row.header_row); // Header row should not be selected
                     row.checked = !row.checked;
+                    if row.checked {
+                        checked_items += 1;
+                    } else {
+                        unchecked_items += 1;
+                    }
                 }
                 row
             })
             .collect::<Vec<_>>();
-        return Some(ModelRc::new(VecModel::from(new_model)));
+        return (checked_items, unchecked_items, Some(ModelRc::new(VecModel::from(new_model))));
     } else if !selection.selected_rows.is_empty() {
         trace!("[FAST][ONE_BY_ONE] reverse selection(SPACE)");
         for id in &selection.selected_rows {
@@ -684,10 +694,15 @@ fn rows_reverse_checked_selection(selection: &SelectionData, model: &ModelRc<Mai
             assert!(model_data.selected_row);
             assert!(!model_data.header_row);
             model_data.checked = !model_data.checked;
+            if model_data.checked {
+                checked_items += 1;
+            } else {
+                unchecked_items += 1;
+            }
             model.set_row_data(*id, model_data);
         }
     }
-    None
+    (checked_items, unchecked_items, None)
 }
 
 #[cfg(test)]
@@ -933,23 +948,27 @@ mod tests {
 
     #[test]
     fn rows_reverse_checked_selection_with_selected_rows() {
-        let mut model = get_model_vec(3);
+        let mut model = get_model_vec(4);
         model[0].selected_row = true;
         model[1].selected_row = true;
+        model[2].selected_row = true;
+        model[2].checked = true;
         let model = create_model_from_model_vec(&model);
 
         let selection = SelectionData {
-            number_of_selected_rows: 2,
-            selected_rows: vec![0, 1],
+            number_of_selected_rows: 3,
+            selected_rows: vec![0, 1, 2],
             exceeded_limit: false,
         };
 
-        let new_model = rows_reverse_checked_selection(&selection, &model);
+        let (checked_items, unchecked_items, new_model) = rows_reverse_checked_selection(&selection, &model);
 
         assert!(new_model.is_none());
         assert!(model.row_data(0).unwrap().checked);
         assert!(model.row_data(1).unwrap().checked);
         assert!(!model.row_data(2).unwrap().checked);
+        assert_eq!(checked_items, 2);
+        assert_eq!(unchecked_items, 1);
     }
 
     #[test]
@@ -965,12 +984,14 @@ mod tests {
             exceeded_limit: true,
         };
 
-        let new_model = rows_reverse_checked_selection(&selection, &model);
+        let (checked_items, unchecked_items, new_model) = rows_reverse_checked_selection(&selection, &model);
 
         assert!(new_model.is_some());
         let new_model = new_model.unwrap();
         assert!(new_model.row_data(0).unwrap().checked);
         assert!(new_model.row_data(1).unwrap().checked);
         assert!(!new_model.row_data(2).unwrap().checked);
+        assert_eq!(checked_items, 2);
+        assert_eq!(unchecked_items, 0);
     }
 }

krokiet/ui/selectable_tree_view.slint

@@ -116,8 +116,10 @@ export component SelectableTableView inherits Rectangle {
                         checked: r.checked && !r.header_row;
                         width: root.column_sizes[0];
                         toggled => {
-                            r.checked = self.checked;
-                            Callabler.change_number_of_checked_items(self.checked ? 1 : -1);
+                            Callabler.change_number_of_checked_items(r.checked ? -1 : 1);
+                            r.checked = !r.checked; 
+                            // TODO - this is equivalent to r.checked = self.checked, but for now it works better, because self.checked contains sometimes old state
+                            // https://github.com/slint-ui/slint/issues/602
                         }
                     }
 
@@ -136,7 +138,7 @@ export component SelectableTableView inherits Rectangle {
         }
     }
 
-    // Already rust code should deal with selections in the model, but this one is not able to handle
+    // Already rust code should deal with selections in the model, but not all state is available in rust code
     public function reset_selection() {
         start_shift_idx = -1;
         last_selected_idx = -1;

misc/test_compilation_speed_size/src/main.rs

@@ -6,7 +6,7 @@ use std::path::Path;
 
 use walkdir::WalkDir;
 
-use crate::model::{BuildOrCheck, CodegenUnits, Config, Incremental, LTO, OptLevel, OverflowChecks, Panic, Results, SplitDebug, Debugg};
+use crate::model::{BuildOrCheck, CodegenUnits, Config, Debugg, Incremental, OptLevel, OverflowChecks, Panic, Results, SplitDebug, LTO};
 
 const START_CONFIG_TOML: &str = r#"[workspace]
 members = [
@@ -120,10 +120,10 @@ fn get_configs() -> Vec<Config> {
     release_thin_lto.name = "release + thin lto";
     release_thin_lto.lto = LTO::Thin;
 
-    let mut release_thin_lto = release_base.clone();
-    release_thin_lto.name = "release + thin lto + optimize size";
-    release_thin_lto.lto = LTO::Thin;
-    release_thin_lto.opt_level = OptLevel::S;
+    let mut release_thin_lto_optimize_size = release_base.clone();
+    release_thin_lto_optimize_size.name = "release + thin lto + optimize size";
+    release_thin_lto_optimize_size.lto = LTO::Thin;
+    release_thin_lto_optimize_size.opt_level = OptLevel::S;
 
     let mut release_full_lto = release_base.clone();
     release_full_lto.name = "release + fat lto";
@@ -135,27 +135,34 @@ fn get_configs() -> Vec<Config> {
     release_fastest.codegen_units = CodegenUnits::One;
     release_fastest.panic = Panic::Abort;
 
-
-    vec![debug_base, release_base, release_thin_lto, release_full_lto, debug_fast_check, check_fast_check, release_fastest]
+    vec![
+        debug_base,
+        release_base,
+        release_thin_lto,
+        release_full_lto,
+        debug_fast_check,
+        check_fast_check,
+        release_fastest,
+        release_thin_lto_optimize_size,
+    ]
 }
 
 fn clean_cargo() {
     println!("Cleaning cargo...");
-    let output = std::process::Command::new("cargo").arg("clean")
+    let output = std::process::Command::new("cargo")
+        .arg("clean")
         .stdout(std::process::Stdio::inherit())
-        .stderr(std::process::Stdio::inherit()).output().expect("Failed to execute cargo clean");
+        .stderr(std::process::Stdio::inherit())
+        .output()
+        .expect("Failed to execute cargo clean");
 
     if !output.status.success() {
         panic!("Cargo clean failed: {}", String::from_utf8_lossy(&output.stderr));
     }
 }
 
 fn run_cargo_build(project: &str, threads_number: u32, build: BuildOrCheck) {
-    let build_check = if build == BuildOrCheck::Build {
-        "build"
-    } else {
-        "check"
-    };
+    let build_check = if build == BuildOrCheck::Build { "build" } else { "check" };
     let mut command = std::process::Command::new("cargo");
     command
         .env("CARGO_BUILD_JOBS", threads_number.to_string())
@@ -165,8 +172,7 @@ fn run_cargo_build(project: &str, threads_number: u32, build: BuildOrCheck) {
         .arg("--profile")
         .arg("fff")
         .stdout(std::process::Stdio::inherit())
-        .stderr(std::process::Stdio::inherit())
-    ;
+        .stderr(std::process::Stdio::inherit());
 
     let output = command.output().expect("Failed to execute cargo build");
 

misc/test_compilation_speed_size/src/model.rs

@@ -163,13 +163,6 @@ pub struct Config {
 
 impl Config {
     pub fn to_str(&self) -> String {
-        // format!(
-        //     "{}\n{}\n{}\n",
-        //     self.lto.to_str(),
-        //     self.debug.to_str(),
-        //     self.opt_level.to_str(),
-        // )
-        // All the fields with to_str split by \n, but without name
         format!(
             "{}\n{}\n{}\n{}\n{}\n{}\n{}\n{}",
             self.lto.to_str(),
@@ -183,7 +176,6 @@ impl Config {
         )
     }
     pub fn to_string_short(&self) -> String {
-        // All the fields with to_str split by space, but without name
         format!(
             "LTO: {}, Debug: {}, Opt: {}, Build/Check: {}, Codegen Units: {}, Panic: {}, Split Debug: {}, Overflow Checks: {}, Incremental: {}",
             self.lto.to_str(),