use fla's get_err_ratio for err computation

Author: garrett361

tests/unit_tests/test_moe.py

@@ -174,19 +174,9 @@ def test_moe_ffn_equivalence(self, iteration: int = 0) -> tuple[float, float]:
                 "moe_old vs ffn", out_ffn, out_moe_old, self.assert_close_ratio
             )
             assert_close("moe vs ffn", out_ffn, out_moe, self.assert_close_ratio)
-            # Compute symmetric mean percentage errors
-            moe_old_rel_err = (
-                2
-                * ((out_moe_old - out_ffn).abs() / (out_ffn.abs() + out_moe.abs()))
-                .mean()
-                .item()
-            )
-            moe_rel_err = (
-                2
-                * ((out_moe - out_ffn).abs() / (out_ffn.abs() + out_moe.abs()))
-                .mean()
-                .item()
-            )
+
+            moe_old_rel_err = get_err_ratio(out_ffn, out_moe_old)
+            moe_rel_err = get_err_ratio(out_ffn, out_moe)
             return moe_old_rel_err, moe_rel_err
 
     def test_perf(
@@ -233,7 +223,7 @@ def test_perf(
     mean_moe_old_rel_err = torch.tensor(moe_old_rel_errs)
     mean_moe_rel_err = torch.tensor(moe_rel_errs)
 
-    print(f"\nACCURACY VS FFN: {accuracy_iters} iterations")
+    print(f"\nACCURACY VS FFN: {accuracy_iters} iterations\n")
     print(f"{mean_moe_old_rel_err.mean()=}, {mean_moe_old_rel_err.std()=}")
     print(f"{mean_moe_rel_err.mean()=}, {mean_moe_rel_err.std()=}")
     print(f"{mean_moe_old_rel_err.mean()/mean_moe_rel_err.mean()=}")
@@ -242,7 +232,7 @@ def test_perf(
     perf_seqlen = 4096
     perf_bsz = 4
     print(
-        f"\nTRITON BENCH: {perf_seqlen=} {perf_bsz=} warmups={t.perf_warmups} repeats={t.perf_reps}"
+        f"\nTRITON BENCH: {perf_seqlen=} {perf_bsz=} warmups={t.perf_warmups} repeats={t.perf_reps}\n"
     )
     t.test_perf(bsz=perf_bsz, seqlen=perf_seqlen)