Skip to content

Commit 7125fe4

Browse files
committed
Fixed type hints
1 parent 36640de commit 7125fe4

File tree

3 files changed

+21
-22
lines changed

3 files changed

+21
-22
lines changed

Tests/test_file_jxl.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,9 @@ def setup_method(self) -> None:
4545

4646
def test_version(self) -> None:
4747
_jpegxl.JpegXlDecoderVersion()
48-
assert re.search(r"\d+\.\d+\.\d+$", features.version_module("jpegxl"))
48+
version = features.version_module("jpegxl")
49+
assert version is not None
50+
assert re.search(r"\d+\.\d+\.\d+$", version)
4951

5052
def test_read_rgb(self) -> None:
5153
"""

Tests/test_file_jxl_metadata.py

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@
2929

3030

3131
def test_read_exif_metadata() -> None:
32-
file_path = "Tests/images/flower.jxl"
33-
with Image.open(file_path) as image:
32+
with Image.open("Tests/images/flower.jxl") as image:
3433
assert image.format == "JPEG XL"
3534
exif_data = image.info.get("exif", None)
3635
assert exif_data
@@ -43,8 +42,8 @@ def test_read_exif_metadata() -> None:
4342
with Image.open("Tests/images/flower.jpg") as jpeg_image:
4443
expected_exif = jpeg_image.info["exif"]
4544

46-
# jpeg xl always returns exif without 'Exif\0\0' prefix
47-
assert exif_data == expected_exif[6:]
45+
# jpeg xl always returns exif without 'Exif\0\0' prefix
46+
assert exif_data == expected_exif[6:]
4847

4948

5049
def test_read_exif_metadata_without_prefix() -> None:
@@ -53,21 +52,20 @@ def test_read_exif_metadata_without_prefix() -> None:
5352
assert im.info["exif"][:6] != b"Exif\x00\x00"
5453

5554
exif = im.getexif()
56-
assert exif[305] == "Adobe Photoshop CS6 (Macintosh)"
55+
assert exif[305] == "Adobe Photoshop CS6 (Macintosh)"
5756

5857

5958
def test_read_icc_profile() -> None:
60-
file_path = "Tests/images/flower2.jxl"
61-
with Image.open(file_path) as image:
59+
with Image.open("Tests/images/flower2.jxl") as image:
6260
assert image.format == "JPEG XL"
6361
assert image.info.get("icc_profile", None)
6462

6563
icc = image.info["icc_profile"]
6664

67-
with Image.open("Tests/images/flower2.jxl") as jpeg_image:
68-
expected_icc = jpeg_image.info["icc_profile"]
65+
with Image.open("Tests/images/flower2.jxl") as jpeg_image:
66+
expected_icc = jpeg_image.info["icc_profile"]
6967

70-
assert icc == expected_icc
68+
assert icc == expected_icc
7169

7270

7371
def test_getxmp() -> None:
@@ -110,7 +108,7 @@ def get_info(self) -> tuple[int, int, str, int, int, int, int, int]:
110108
def get_icc(self) -> None:
111109
pass
112110

113-
def get_exif(self) -> None:
111+
def get_exif(self) -> bytes:
114112
return b"\0\0\0\0"
115113

116114
def get_xmp(self) -> None:

setup.py

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -753,7 +753,7 @@ def build_extensions(self) -> None:
753753
self, "jxl/decode.h"
754754
):
755755
if _find_library_file(self, "jxl"):
756-
feature.set("jpegxl", "jxl jxl_threads")
756+
feature.set("jpegxl", "jxl")
757757

758758
if feature.want("imagequant"):
759759
_dbg("Looking for imagequant")
@@ -838,15 +838,6 @@ def build_extensions(self) -> None:
838838
# alternate Windows name.
839839
feature.set("lcms", "lcms2_static")
840840

841-
if feature.get("jpegxl"):
842-
# jxl and jxl_threads are required
843-
libs = feature.get("jpegxl").split()
844-
defs = []
845-
846-
self._update_extension("PIL._jpegxl", libs, defs)
847-
else:
848-
self._remove_extension("PIL._jpegxl")
849-
850841
if feature.want("webp"):
851842
_dbg("Looking for webp")
852843
if all(
@@ -970,6 +961,14 @@ def build_extensions(self) -> None:
970961
else:
971962
self._remove_extension("PIL._avif")
972963

964+
jpegxl = feature.get("jpegxl")
965+
if isinstance(jpegxl, str):
966+
# jxl and jxl_threads are required
967+
libs = [jpegxl, jpegxl + "_threads"]
968+
self._update_extension("PIL._jpegxl", libs)
969+
else:
970+
self._remove_extension("PIL._jpegxl")
971+
973972
tk_libs = ["psapi"] if sys.platform in ("win32", "cygwin") else []
974973
self._update_extension("PIL._imagingtk", tk_libs)
975974

0 commit comments

Comments
 (0)