server: fix buffer release timing in processUnaryRPC (grpc#7998)

lqs · purnesh42H · commit 91a5a975a89a · 2025-01-31T01:21:57.000+05:30
diff --git a/server.go b/server.go
@@ -1360,8 +1360,16 @@ func (s *Server) processUnaryRPC(ctx context.Context, stream *transport.ServerSt
 		}
 		return err
 	}
-	defer d.Free()
+	freed := false
+	dataFree := func() {
+		if !freed {
+			d.Free()
+			freed = true
+		}
+	}
+	defer dataFree()
 	df := func(v any) error {
+		defer dataFree()
 		if err := s.getCodec(stream.ContentSubtype()).Unmarshal(d, v); err != nil {
 			return status.Errorf(codes.Internal, "grpc: error unmarshalling request: %v", err)
 		}

Original file line number	Diff line number	Diff line change
`@@ -1360,8 +1360,16 @@ func (s Server) processUnaryRPC(ctx context.Context, stream transport.ServerSt`
`1360`	`1360`	`}`
`1361`	`1361`	`return err`
`1362`	`1362`	`}`
`1363`		`- defer d.Free()`
	`1363`	`+ freed := false`
	`1364`	`+ dataFree := func() {`
	`1365`	`+ if !freed {`
	`1366`	`+ d.Free()`
	`1367`	`+ freed = true`
	`1368`	`+ }`
	`1369`	`+ }`
	`1370`	`+ defer dataFree()`
`1364`	`1371`	`df := func(v any) error {`
	`1372`	`+ defer dataFree()`
`1365`	`1373`	`if err := s.getCodec(stream.ContentSubtype()).Unmarshal(d, v); err != nil {`
`1366`	`1374`	`return status.Errorf(codes.Internal, "grpc: error unmarshalling request: %v", err)`
`1367`	`1375`	`}`