Skip to content

Commit 30ed452

Browse files
zhangskzcopybara-github
authored andcommitted
Breaking Change: Remove deprecated Arena::GetArena.
This has been marked ABSL_DEPRECATED as of v4.23.x and should be replaced with a direct call to value->GetArena for performance reasons. See https://engdoc.corp.google.com/eng/doc/devguide/proto/news/2024-10-02.md#arenagetarena PiperOrigin-RevId: 700488709
1 parent 5bb4555 commit 30ed452

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

src/google/protobuf/arena.h

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -345,18 +345,6 @@ class PROTOBUF_EXPORT PROTOBUF_ALIGNAS(8) Arena final {
345345
impl_.AddCleanup(object, destruct);
346346
}
347347

348-
// Retrieves the arena associated with |value| if |value| is an arena-capable
349-
// message, or nullptr otherwise. If possible, the call resolves at compile
350-
// time. Note that we can often devirtualize calls to `value->GetArena()` so
351-
// usually calling this method is unnecessary.
352-
// TODO: remove this function.
353-
template <typename T>
354-
ABSL_DEPRECATED(
355-
"This will be removed in a future release. Call value->GetArena() "
356-
"instead.")
357-
PROTOBUF_ALWAYS_INLINE static Arena* GetArena(T* value) {
358-
return GetArenaInternal(value);
359-
}
360348

361349
template <typename T>
362350
class InternalHelper {

0 commit comments

Comments
 (0)