Skip to content

Commit 0412f5a

Browse files
committed
Fixed condition, when local dns lookup should happen.
Bug was introduced with option proy_from_enviroment with release V0.24. Signed-off-by: Ulrike Klusik <[email protected]>
1 parent 3dd5dfe commit 0412f5a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

prober/http.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ func ProbeHTTP(ctx context.Context, target string, module config.Module, registr
328328
targetPort := targetURL.Port()
329329

330330
var ip *net.IPAddr
331-
if !module.HTTP.SkipResolvePhaseWithProxy || module.HTTP.HTTPClientConfig.ProxyConfig.ProxyURL.URL == nil || module.HTTP.HTTPClientConfig.ProxyConfig.ProxyFromEnvironment {
331+
if !module.HTTP.SkipResolvePhaseWithProxy || (module.HTTP.HTTPClientConfig.ProxyConfig.ProxyURL.URL == nil && !module.HTTP.HTTPClientConfig.ProxyConfig.ProxyFromEnvironment ) {
332332
var lookupTime float64
333333
ip, lookupTime, err = chooseProtocol(ctx, module.HTTP.IPProtocol, module.HTTP.IPProtocolFallback, targetHost, registry, logger)
334334
durationGaugeVec.WithLabelValues("resolve").Add(lookupTime)

0 commit comments

Comments
 (0)