Skip to content

Commit 1b583f4

Browse files
authored
Clean up warnings when running tests (#3433)
1 parent 6c986c4 commit 1b583f4

File tree

8 files changed

+98
-94
lines changed

8 files changed

+98
-94
lines changed

.changeset/friendly-swans-invite.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/view-components": minor
3+
---
4+
5+
Clean up warnings when running tests, limit Ruby support to >= 3.2 and Rails support to >= 7.1.

.github/workflows/test.yml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,6 @@ jobs:
5252
fail-fast: false
5353
matrix:
5454
include:
55-
- rails_version: "6.1.1"
56-
ruby_version: "3.0"
57-
- rails_version: "7.0.3"
58-
ruby_version: "3.0"
5955
- rails_version: "7.1.3"
6056
ruby_version: "3.2"
6157
- rails_version: "7.1.3"
@@ -98,10 +94,6 @@ jobs:
9894
fail-fast: false
9995
matrix:
10096
include:
101-
- rails_version: "6.1.1"
102-
ruby_version: "3.0"
103-
- rails_version: "7.0.3"
104-
ruby_version: "3.0"
10597
- rails_version: "7.1.3"
10698
ruby_version: "3.2"
10799
- rails_version: "7.1.3"
@@ -144,10 +136,6 @@ jobs:
144136
fail-fast: false
145137
matrix:
146138
include:
147-
- rails_version: "6.1.1"
148-
ruby_version: "3.0"
149-
- rails_version: "7.0.3"
150-
ruby_version: "3.0"
151139
- rails_version: "7.1.3"
152140
ruby_version: "3.2"
153141
- rails_version: "7.1.3"

Gemfile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
source "https://rubygems.org"
44

55
gemspec
6-
rails_version = (ENV["RAILS_VERSION"] || "7.1.3.2").to_s
6+
rails_version = (ENV["RAILS_VERSION"] || "8.0.2").to_s
77

88
gem "rack-cors"
99
gem "rake", "~> 13.2"
@@ -33,7 +33,7 @@ gem "puma", "~> 6.4.2"
3333
# Reduces boot times through caching; required in config/boot.rb
3434
gem "bootsnap", ">= 1.4.2", require: false
3535

36-
gem "lookbook", "~> 2.3.5" unless rails_version.to_f < 7
36+
gem "lookbook", "~> 2.3.8"
3737
gem "view_component", path: ENV["VIEW_COMPONENT_PATH"] if ENV["VIEW_COMPONENT_PATH"]
3838

3939
gem "kramdown", "~> 2.4"
@@ -49,7 +49,8 @@ end
4949
# development dependencies
5050
group :development do
5151
gem "allocation_stats", "~> 0.1"
52-
gem "benchmark-ips", "~> 2.13.0"
52+
gem "benchmark"
53+
gem "benchmark-ips", "~> 2"
5354
gem "capybara", "~> 3.40.0"
5455
gem "cuprite", "~> 0.15"
5556
gem "debug"
@@ -58,7 +59,6 @@ group :development do
5859
gem "listen", "~> 3.9"
5960
gem "matrix", "~> 0.4.2"
6061
gem "mocha"
61-
gem "pry"
6262
gem "rubocop"
6363
gem "rubocop-github", "~> 0.20.0"
6464
gem "rubocop-performance"
@@ -71,5 +71,5 @@ group :development do
7171
gem "sprockets-rails"
7272
gem "thor"
7373
gem "timecop"
74-
gem "yard", "~> 0.9.36"
74+
gem "yard", "~> 0.9.37"
7575
end

0 commit comments

Comments
 (0)