Skip to content

Commit db0b27a

Browse files
authored
chore: Migrate from toggleSxComponent to BoxWithFallback helper (#6311)
1 parent 8210573 commit db0b27a

File tree

9 files changed

+50
-192
lines changed

9 files changed

+50
-192
lines changed

.changeset/afraid-papayas-allow.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/react": patch
3+
---
4+
5+
chore: Migrate from toggleSxComponent to BoxWithFallback helper

packages/react/src/Breadcrumbs/Breadcrumbs.tsx

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import type {SxProp} from '../sx'
55
import type {ComponentProps} from '../utils/types'
66
import classes from './Breadcrumbs.module.css'
77
import type {ForwardRefComponent as PolymorphicForwardRefComponent} from '../utils/polymorphic'
8-
import {toggleSxComponent} from '../internal/utils/toggleSxComponent'
8+
import {BoxWithFallback} from '../internal/components/BoxWithFallback'
99

1010
const SELECTED_CLASS = 'selected'
1111

@@ -19,13 +19,12 @@ const BreadcrumbsList = ({children}: React.PropsWithChildren) => {
1919
return <ol className={classes.BreadcrumbsList}>{children}</ol>
2020
}
2121

22-
const BreadcrumbsBaseComponent = toggleSxComponent('nav') as React.ComponentType<BreadcrumbsProps>
2322
function Breadcrumbs({className, children, sx: sxProp}: BreadcrumbsProps) {
2423
const wrappedChildren = React.Children.map(children, child => <li className={classes.ItemWrapper}>{child}</li>)
2524
return (
26-
<BreadcrumbsBaseComponent className={clsx(className, classes.BreadcrumbsBase)} aria-label="Breadcrumbs" sx={sxProp}>
25+
<BoxWithFallback as="nav" className={clsx(className, classes.BreadcrumbsBase)} aria-label="Breadcrumbs" sx={sxProp}>
2726
<BreadcrumbsList>{wrappedChildren}</BreadcrumbsList>
28-
</BreadcrumbsBaseComponent>
27+
</BoxWithFallback>
2928
)
3029
}
3130

@@ -37,10 +36,10 @@ type StyledBreadcrumbsItemProps = {
3736
React.HTMLAttributes<HTMLAnchorElement> &
3837
React.ComponentPropsWithRef<'a'>
3938

40-
const BreadcrumbsItemBaseComponent = toggleSxComponent('a') as React.ComponentType<StyledBreadcrumbsItemProps>
4139
const BreadcrumbsItem = React.forwardRef(({selected, className, ...rest}, ref) => {
4240
return (
43-
<BreadcrumbsItemBaseComponent
41+
<BoxWithFallback
42+
as="a"
4443
className={clsx(className, classes.Item, {
4544
[SELECTED_CLASS]: selected,
4645
[classes.ItemSelected]: selected,

0 commit comments

Comments
 (0)