Skip to content

fix: Ensure main thread on InternalCardComponentsManager loading state #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

fix: Ensure main thread on InternalCardComponentsManager loading state #1383

merged 1 commit into from
Oct 28, 2025
+16 −14

Conversation

@OnurVar
Copy link
Contributor

@OnurVar OnurVar commented Oct 24, 2025 •
edited by atlassian bot
Loading

ESC-714

Description

  • Add @mainactor to isLoading delegate method
  • Add synchronous deinit cleanup for loading state

Contributor Checklist

  • All status checks have passed prior to code review
  • I have added unit tests to a reasonable level of coverage where suitable
  • I have added UI tests to new user flows, if applicable
  • I have manually tested newly added UX
  • I have open a documentation PR, if applicable

Reviewer Checklist

  • I have verified that a suitable set of automated tests has been added
  • I have verified that the title prefix aligns to the code changes + whether a release is expected after merging the PR
  • I have verified the documentation PR aligns with this PR, if applicable

Before Merging

  • If introducing a breaking change, I have communicated it internally
  • Any related documentation PRs are ready to merge

@OnurVar OnurVar self-assigned this Oct 24, 2025
@OnurVar OnurVar marked this pull request as ready for review October 24, 2025 21:39
@OnurVar OnurVar requested a review from a team as a code owner October 24, 2025 21:39
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025 •
edited
Loading

Warnings
⚠️ This PR doesn't seem to contain any updated Unit Test 🤔. Please consider double checking it.🙏

Generated by 🚫 Danger Swift against 76ef0f3

@OnurVar OnurVar force-pushed the ov/fix/card-components-thread-crash branch 2 times, most recently from 8f449fe to 313cd41 Compare October 26, 2025 21:12
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2025

Appetize link: https://appetize.io/app/rbic2e44nh46qwqrlgzgphe35m

@OnurVar OnurVar force-pushed the ov/fix/card-components-thread-crash branch from 313cd41 to 76ef0f3 Compare October 27, 2025 21:46
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 27, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
54.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

semirp
semirp approved these changes Oct 28, 2025
View reviewed changes
Copy link
Contributor

@semirp semirp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PCI ok

@OnurVar OnurVar merged commit 06a798d into master Oct 28, 2025
11 checks passed
@OnurVar OnurVar deleted the ov/fix/card-components-thread-crash branch October 28, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@semirp semirp semirp approved these changes

@borisprimer borisprimer borisprimer approved these changes

@henry-cooper-primer henry-cooper-primer henry-cooper-primer approved these changes

Assignees

@OnurVar OnurVar

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@OnurVar @semirp @borisprimer @henry-cooper-primer