Add explicit @mainactor to NavigationLink initializer (#3430)

* Add explicit @mainactor to NavigationLink initializer

* Access Notification from within an explicit Task

Fixes the "Conformance of 'Notification' to 'Sendable' is unavailable" error

* Revert "Add explicit @mainactor to NavigationLink initializer"

This reverts commit d8cb070.

* Add explicit @mainactor to NavigationLink initializer

* Update Examples/CaseStudies/SwiftUICaseStudies/03-Effects-LongLiving.swift

Co-authored-by: Brandon Williams <[email protected]>

* Update swift-navigation dependency version to 2.2.2

* Discard changes to Examples/CaseStudies/CaseStudies.xcodeproj/project.pbxproj

* Update ComposableArchitecture.xcworkspace/xcshareddata/swiftpm/Package.resolved

* Update ComposableArchitecture.xcworkspace/xcshareddata/swiftpm/Package.resolved

* Update ComposableArchitecture.xcworkspace/xcshareddata/swiftpm/Package.resolved

* Update ComposableArchitecture.xcworkspace/xcshareddata/swiftpm/Package.resolved

* Update ComposableArchitecture.xcworkspace/xcshareddata/swiftpm/Package.resolved

* Update ComposableArchitecture.xcworkspace/xcshareddata/swiftpm/Package.resolved

* Update Package@swift-6

* Fix tests

---------

Co-authored-by: Brandon Williams <[email protected]>
Co-authored-by: Brandon Williams <[email protected]>

Author: chrisjrex

ComposableArchitecture.xcworkspace/xcshareddata/swiftpm/Package.resolved

@@ -26,7 +26,7 @@ let package = Package(
     .package(url: "https://github.com/pointfreeco/swift-dependencies", from: "1.4.0"),
     .package(url: "https://github.com/pointfreeco/swift-identified-collections", from: "1.1.0"),
     .package(url: "https://github.com/pointfreeco/swift-macro-testing", from: "0.2.0"),
-    .package(url: "https://github.com/pointfreeco/swift-navigation", from: "2.1.0"),
+    .package(url: "https://github.com/pointfreeco/swift-navigation", from: "2.2.2"),
     .package(url: "https://github.com/pointfreeco/swift-perception", from: "1.3.4"),
     .package(url: "https://github.com/pointfreeco/xctest-dynamic-overlay", from: "1.3.0"),
     .package(url: "https://github.com/swiftlang/swift-docc-plugin", from: "1.0.0"),

Package.resolved

@@ -26,7 +26,7 @@ let package = Package(
     .package(url: "https://github.com/pointfreeco/swift-dependencies", from: "1.4.0"),
     .package(url: "https://github.com/pointfreeco/swift-identified-collections", from: "1.1.0"),
     .package(url: "https://github.com/pointfreeco/swift-macro-testing", from: "0.2.0"),
-    .package(url: "https://github.com/pointfreeco/swift-navigation", from: "2.1.0"),
+    .package(url: "https://github.com/pointfreeco/swift-navigation", from: "2.2.2"),
     .package(url: "https://github.com/pointfreeco/swift-perception", from: "1.3.4"),
     .package(url: "https://github.com/pointfreeco/xctest-dynamic-overlay", from: "1.3.0"),
     .package(url: "https://github.com/swiftlang/swift-docc-plugin", from: "1.0.0"),

Package.swift

@@ -230,6 +230,9 @@ extension NavigationLink where Destination == Never {
   ///   - state: An optional value to present. When the user selects the link, SwiftUI stores a
   ///     copy of the value. Pass a `nil` value to disable the link.
   ///   - label: A label that describes the view that this link presents.
+  #if compiler(>=6)
+    @MainActor
+  #endif
   public init<P, L: View>(
     state: P?,
     @ViewBuilder label: () -> L,
@@ -266,6 +269,9 @@ extension NavigationLink where Destination == Never {
   ///     presents.
   ///   - state: An optional value to present. When the user selects the link, SwiftUI stores a
   ///     copy of the value. Pass a `nil` value to disable the link.
+  #if compiler(>=6)
+    @MainActor
+  #endif
   public init<P>(
     _ titleKey: LocalizedStringKey, state: P?, fileID: StaticString = #fileID, line: UInt = #line
   )
@@ -286,6 +292,9 @@ extension NavigationLink where Destination == Never {
   ///   - title: A string that describes the view that this link presents.
   ///   - state: An optional value to present. When the user selects the link, SwiftUI stores a
   ///     copy of the value. Pass a `nil` value to disable the link.
+  #if compiler(>=6)
+    @MainActor
+  #endif
   @_disfavoredOverload
   public init<S: StringProtocol, P>(
     _ title: S, state: P?, fileID: StaticString = #fileID, line: UInt = #line

[email protected]

@@ -388,26 +388,30 @@ final class EffectCancellationTests: BaseTCATestCase {
       }
       uncheckedUseMainSerialExecutor = false
       await Task.yield()
-      XCTAssertTrue(!Thread.isMainThread)
+      XCTAssertTrue(!Thread.isMainThread, "Should not be on main thread")
       let ids = (1...100).map { _ in UUID() }
 
       let areCancelled = await withTaskGroup(of: Bool.self, returning: [Bool].self) { group in
         (1...10_000).forEach { index in
           let id = ids[index.quotientAndRemainder(dividingBy: ids.count).remainder]
           group.addTask {
             await withTaskCancellation(id: id) {
-              nil == (try? await Task.sleep(nanoseconds: 2_000_000_000))
+              nil == (try? await Task.sleep(nanoseconds: 10_000_000_000))
             }
           }
-          Task {
+          group.addTask {
             try? await Task.sleep(nanoseconds: .random(in: 1_000_000...2_000_000))
             Task.cancel(id: id)
+            return true
           }
         }
         return await group.reduce(into: [Bool]()) { $0.append($1) }
       }
 
-      XCTAssertTrue(areCancelled.allSatisfy({ isCancelled in isCancelled }))
+      XCTAssertTrue(
+        areCancelled.allSatisfy({ isCancelled in isCancelled }),
+        "All tasks should be cancelled"
+      )
 
       for id in ids {
         XCTAssertEqual(