Abstract getPosition() in traits

we don't technically need to do this, but I suppose it's nicer for people who don't use a static analyser.

Author: dktapps

src/block/utils/ContainerTrait.php

@@ -54,19 +54,25 @@ public function isOpeningObstructed() : bool{
 		return false;
 	}
 
+	abstract protected function getPosition() : Position;
+
+	protected function getTile() : ?ContainerTile{
+		$pos = $this->getPosition();
+		$tile = $pos->getWorld()->getTile($pos);
+		return $tile instanceof ContainerTile ? $tile : null;
+	}
+
 	public function canOpenWith(string $key) : bool{
 		//TODO: maybe we can bring the key to the block in readStateFromWorld()?
-		$tile = $this->position->getWorld()->getTile($this->position);
-		return $tile instanceof ContainerTile && $tile->canOpenWith($key);
+		return $this->getTile()?->canOpenWith($key) ?? false;
 	}
 
 	public function openToUnchecked(Player $player) : bool{
-		$tile = $this->position->getWorld()->getTile($this->position);
-		return $tile instanceof ContainerTile && $player->setCurrentWindow($this->newMenu($player, $tile->getInventory(), $this->position));
+		$tile = $this->getTile();
+		return $tile !== null && $player->setCurrentWindow($this->newMenu($player, $tile->getInventory(), $this->getPosition()));
 	}
 
 	public function getInventory() : ?Inventory{
-		$tile = $this->position->getWorld()->getTile($this->position);
-		return $tile instanceof ContainerTile ? $tile->getInventory() : null;
+		return $this->getTile()?->getInventory();
 	}
 }

src/block/utils/MenuAccessorTrait.php

@@ -50,7 +50,9 @@ public function isOpeningObstructed() : bool{
 		return false;
 	}
 
+	abstract protected function getPosition() : Position;
+
 	public function openToUnchecked(Player $player) : bool{
-		return $player->setCurrentWindow($this->newMenu($player, $this->position));
+		return $player->setCurrentWindow($this->newMenu($player, $this->getPosition()));
 	}
 }