fix(question_condition): fix non static method

Signed-off-by: Thierry Bugier <[email protected]>

Author: btry

inc/question_condition.class.php

@@ -67,7 +67,7 @@ public static function getEnumShowLogic() {
       ];
    }
 
-   public function getEnumShowCondition() {
+   public static function getEnumShowCondition() {
       return [
          self::SHOW_CONDITION_EQ => '=',
          self::SHOW_CONDITION_NE => '≠',
@@ -204,8 +204,6 @@ public function getConditionsFromQuestion($questionId) {
     * @return string
     */
    public function getConditionHtml($form_id, $questionId = 0, $isFirst = false) {
-      global $CFG_GLPI;
-
       if ($this->isNewItem()) {
          $show_field       = '';
          $show_condition   = PluginFormcreatorQuestion_Condition::SHOW_CONDITION_EQ;

tests/suite-unit/PluginFormcreatorQuestion_Condition.php

@@ -48,7 +48,7 @@ public function testGetEnumShowLogic() {
    }
 
    public function testGetEnumShowCondition() {
-      $output = \PluginFormcreatorQuestion_Condition::getEnumShowLogic();
+      $output = \PluginFormcreatorQuestion_Condition::getEnumShowCondition();
       $this->array($output)
          ->isIdenticalTo([
             '1' => '=',