fix(glpiselectfield): prevent use of the field with non existing itemtype

Signed-off-by: Thierry Bugier <[email protected]>

Author: btry

inc/fields/glpiselectfield.class.php

@@ -31,10 +31,6 @@
 
 class PluginFormcreatorGlpiselectField extends PluginFormcreatorDropdownField
 {
-   public function isPrerequisites() {
-      return true;
-   }
-
    public function getDesignSpecializationField() {
       $rand = mt_rand();
 

tests/suite-unit/PluginFormcreatorDropdownField.php

@@ -108,8 +108,17 @@ public function testIsAnonymousFormCompatible() {
 
    public function testIsPrerequisites() {
       $instance = $this->newTestedInstance(new \PluginFormcreatorQuestion());
+      $instance = $this->newTestedInstance($this->getQuestion([
+         'values' => \Computer::class
+      ]));
       $output = $instance->isPrerequisites();
       $this->boolean($output)->isEqualTo(true);
+
+      $instance = $this->newTestedInstance($this->getQuestion([
+         'values' => \UndefinedItemtype::class
+      ]));
+      $output = $instance->isPrerequisites();
+      $this->boolean($output)->isEqualTo(false);
    }
 
    public function testGetValueForDesign() {

tests/suite-unit/PluginFormcreatorSelectField.php

@@ -152,12 +152,6 @@ public function testIsAnonymousFormCompatible() {
       $this->boolean($output)->isTrue();
    }
 
-   public function testIsPrerequisites() {
-      $instance = $this->newTestedInstance($this->getQuestion());
-      $output = $instance->isPrerequisites();
-      $this->boolean($output)->isEqualTo(true);
-   }
-
    public function testCanRequire() {
       $instance = new \PluginFormcreatorSelectField($this->getQuestion());
       $output = $instance->canRequire();