Skip to content

Commit b414ee0

Browse files
committed
fix(textareafield): visual glitches
if a textarea is visibles after scrollong and under a condition, triggering on and off teh conditin may lead to a partially visible areal (only the toolbar) Signed-off-by: Thierry Bugier <[email protected]>
1 parent ded963f commit b414ee0

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

js/scripts.js.php

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -626,9 +626,9 @@ function formcreatorShowFields(form) {
626626
var sectionId = parseInt(sectionKey);
627627
if (!isNaN(sectionId)) {
628628
if (sectionToShow[sectionId]) {
629-
$('div[data-section-id="' + sectionId+ '"]').show();
629+
$('div[data-section-id="' + sectionId+ '"]').css('visibility', '');
630630
} else {
631-
$('div[data-section-id="' + sectionId+ '"]').hide();
631+
$('div[data-section-id="' + sectionId+ '"]').css('visibility', 'hidden');
632632
}
633633
}
634634
}
@@ -638,12 +638,14 @@ function formcreatorShowFields(form) {
638638
questionId = parseInt(questionKey.replace('formcreator_field_', ''));
639639
if (!isNaN(questionId)) {
640640
if (questionToShow[questionKey]) {
641-
$('#form-group-field-' + questionKey).show();
641+
$('#form-group-field-' + questionKey).css('visibility', '');
642+
$('#form-group-field-' + questionKey).css('height', '');
642643
i++;
643644
$('#form-group-field-' + questionKey).removeClass('line' + (i+1) % 2);
644645
$('#form-group-field-' + questionKey).addClass('line' + i%2);
645646
} else {
646-
$('#form-group-field-' + questionKey).hide();
647+
$('#form-group-field-' + questionKey).css('visibility', 'hidden');
648+
$('#form-group-field-' + questionKey).css('height', '0');
647649
$('#form-group-field-' + questionKey).removeClass('line0');
648650
$('#form-group-field-' + questionKey).removeClass('line1');
649651
}

0 commit comments

Comments
 (0)