fix(issue): SQL warning if groups of the user contain an empty ID

btry · btry · commit 580eba5b355e · 2024-09-12T13:26:19.000+02:00
empty string unexpected
diff --git a/hook.php b/hook.php
@@ -205,6 +205,7 @@ function plugin_formcreator_addDefaultWhere($itemtype) {
             $groupList[] = $group['id'];
          }
          if (count($groupList) > 0) {
+            $groupList = array_filter($groupList);
             $groupList = implode("', '", $groupList);
             // Search option ID 16 is either from Formcreator, either from AdvForms
             $complexJoinId = Search::computeComplexJoinID($issueSearchOptions[16]['joinparams']);

Original file line number	Diff line number	Diff line change
`@@ -205,6 +205,7 @@ function plugin_formcreator_addDefaultWhere($itemtype) {`
`205`	`205`	`$groupList[] = $group['id'];`
`206`	`206`	`}`
`207`	`207`	`if (count($groupList) > 0) {`
	`208`	`+ $groupList = array_filter($groupList);`
`208`	`209`	`$groupList = implode("', '", $groupList);`
`209`	`210`	`// Search option ID 16 is either from Formcreator, either from AdvForms`
`210`	`211`	`$complexJoinId = Search::computeComplexJoinID($issueSearchOptions[16]['joinparams']);`