test: add tsts

Signed-off-by: Thierry Bugier <[email protected]>

Author: btry

inc/form.class.php

@@ -228,7 +228,6 @@ public function rawSearchOptions() {
     * @return String                 Html string to be displayed for the form field
     */
    public static function getSpecificValueToSelect($field, $name = '', $values = '', array $options = []) {
-
       if (!is_array($values)) {
          $values = [$field => $values];
       }
@@ -607,11 +606,6 @@ public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0) {
       global $DB;
 
       switch ($item->getType()) {
-         case PluginFormcreatorConfig::class:
-            $found  = $DB->request(self::getTable(), []);
-            $number = count($found);
-            return self::createTabEntry(self::getTypeName($number), $number);
-            break;
          case PluginFormcreatorForm::class:
             $nb = 0;
             foreach ($this->getTargetTypes() as $targetType) {
@@ -632,7 +626,7 @@ public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0) {
                2 => __('Preview'),
             ];
             break;
-         case 'Central':
+         case Central::class:
             return _n('Form', 'Forms', Session::getPluralNumber(), 'formcreator');
             break;
       }
@@ -1903,7 +1897,7 @@ public static function import(PluginFormcreatorLinker $linker, $input = [], $con
       // Find an existing form to update, only if an UUID is available
       $itemId = false;
       /** @var string $idKey key to use as ID (id or uuid) */
-      $idKey = 'id'; 
+      $idKey = 'id';
       if (isset($input['uuid'])) {
          // Try to find an existing item to update
          $idKey = 'uuid';

tests/suite-unit/PluginFormcreatorForm.php

@@ -39,6 +39,7 @@ public function beforeTestMethod($method) {
       parent::beforeTestMethod($method);
       switch ($method) {
          case 'testImport':
+         case 'testCanPurgeItem':
             self::login('glpi', 'glpi');
       }
    }
@@ -113,6 +114,19 @@ public function testCanPurge() {
       $this->boolean((bool) $output)->isFalse();
    }
 
+   public function testCanPurgeItem() {
+      $form = $this->getForm();
+      $output = $form->canPurgeItem();
+      $this->boolean((boolean) $output)->isTrue();
+
+      $form->saveForm([
+         \PluginFormcreatorForm::getForeignKeyField() => $form->getID(),
+      ]);
+
+      $output = $form->canPurgeItem();
+      $this->boolean((boolean) $output)->isFalse();
+   }
+
    protected function formProvider() {
       return [
          [
@@ -204,18 +218,81 @@ public function testPrepareInputForUpdate($input, $expected, $expectedMessage) {
       }
    }
 
-   /**
-    * @dataProvider formProvider
-    */
-   public function testPurgeForm($formData) {
-      $form = new \PluginFormcreatorForm();
-      $form->add($formData);
-      $this->boolean($form->isNewItem())->isFalse();
+   public function testDefineTabs() {
+      $form = $this->getForm();
+      $output = $form->defineTabs();
+      $this->array($output)->isEqualTo([
+         'PluginFormcreatorForm$main' => "Form",
+         'PluginFormcreatorQuestion$1' => "Questions",
+         'PluginFormcreatorForm_Profile$1' => "Access types",
+         'PluginFormcreatorForm$1' => "Targets",
+         'PluginFormcreatorForm$2' => "Preview",
+         'PluginFormcreatorFormAnswer$1' => "Form answers",
+      ]);
+   }
+
+   public function testGetTabNameForItem() {
+      $form = $this->getForm();
+      $item = new \Central();
+      $output = $form->getTabNameForItem($item);
+      $this->string($output)->isEqualTo('Forms');
+
+      $item = $form;
+      $output = $form->getTabNameForItem($item);
+      $this->array($output)->isEqualTo([
+         1 => 'Targets',
+         2 => 'Preview',
+      ]);
+
+      $item = new \User();
+      $output = $form->getTabNameForItem($item);
+      $this->string($output)->isEqualTo('');
+   }
+
+   public function testPost_purgeItem() {
+      $form = $this->getForm([
+         'validation_required' => \PluginFormcreatorForm_Validator::VALIDATION_USER,
+         'users_id' => 2, // glpi
+      ]);
+      $section = $this->getSection([
+         'plugin_formcreator_forms_id' => $form->getID(),
+      ]);
+      $targetChange = $this->getTargetChange([
+         'plugin_formcreator_forms_id' => $form->getID(),
+      ]);
+      $targetTicket = $this->getTargetTicket([
+         'plugin_formcreator_forms_id' => $form->getID(),
+      ]);
+      $validator = new \PluginFormcreatorForm_Validator();
+      $validator->getFromDBByCrit([
+         'plugin_formcreator_forms_id' => $form->getID(),
+         'itemtype' => \User::class,
+      ]);
 
-      $success = $form->delete([
-         'id'              => $form->getID(),
+      $formProfile = new \PluginFormcreatorForm_Profile();
+      $formProfile->add([
+         'plugin_formcreator_forms_id' => $form->getID(),
+         'profiles_id' => 6 // technician
+      ]);
+
+      $form->delete([
+         'id' => $form->getID(),
       ], 1);
-      $this->boolean($success)->isTrue();
+
+      $output = $section->getFromDB($section->getID()) ;
+      $this->boolean($output)->isFalse();
+
+      $output = $targetChange->getFromDB($targetChange->getID());
+      $this->boolean($output)->isFalse();
+
+      $output = $targetTicket->getFromDB($targetTicket->getID());
+      $this->boolean($output)->isFalse();
+
+      $output = $validator->getFromDB($validator->getID());
+      $this->boolean($output)->isFalse();
+
+      $output = $formProfile->getFromDB($formProfile->getID());
+      $this->boolean($output)->isFalse();
    }
 
    public function testCreateValidationNotification() {