Fix SmallArray::add_array bug causing exponential memory allocation

timothyschoen · timothyschoen · commit 7e7472a2886c · 2025-09-20T19:55:14.000+02:00
diff --git a/Source/Utility/Containers.h b/Source/Utility/Containers.h
@@ -808,7 +808,7 @@ class SmallArrayImpl : public SmallArrayTemplateBase<T> {
     template<typename U>
     void add_array(U const& array)
     {
-        this->reserve(this->capacity() + array.size());
+        this->reserve(std::max<size_t>(this->capacity(), array.size()));
         for (auto const& elt : array)
             this->add(elt);
     }

Original file line number	Diff line number	Diff line change
`@@ -808,7 +808,7 @@ class SmallArrayImpl : public SmallArrayTemplateBase<T> {`
`808`	`808`	`template<typename U>`
`809`	`809`	`void add_array(U const& array)`
`810`	`810`	`{`
`811`		`- this->reserve(this->capacity() + array.size());`
	`811`	`+ this->reserve(std::max<size_t>(this->capacity(), array.size()));`
`812`	`812`	`for (auto const& elt : array)`
`813`	`813`	`this->add(elt);`
`814`	`814`	`}`