On update race condition (#471)

* guard updates between transition

* simplify check

* async as well

* remove some logs

* more comment removal

* lint

* move logic out of view

* fix tests

* revert typing change

* remove top level reset of view transition state, leaving responsibility up to view

* android check as well

* cancel previous render job from android if new render job is launched

* nullable job

* revert core changes

* no hermes

* hermes only

* separate default and hermes

* single line

Author: brocollie08

.circleci/config.yml

@@ -293,9 +293,9 @@ jobs:
           command: |
             circle-android wait-for-boot
 
-      - run: |
-          bazel test --config=ci -- //android/demo:android_instrumentation_test
-          bazel test --config=ci --//android/player:runtime=hermes -- //android/demo:android_instrumentation_test
+      - run: bazel test --config=ci -- //android/demo:android_instrumentation_test
+
+      - run: bazel test --config=ci --//android/player:runtime=hermes -- //android/demo:android_instrumentation_test
 
       - run:
           when: always

android/player/src/main/java/com/intuit/playerui/android/ui/PlayerFragment.kt

@@ -32,6 +32,8 @@ import com.intuit.playerui.core.managed.AsyncFlowIterator
 import kotlinx.coroutines.CancellationException
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.Job
+import kotlinx.coroutines.cancel
 import kotlinx.coroutines.flow.collectLatest
 import kotlinx.coroutines.flow.launchIn
 import kotlinx.coroutines.flow.onEach
@@ -88,6 +90,8 @@ public abstract class PlayerFragment : Fragment(), ManagedPlayerState.Listener {
      */
     public abstract val playerViewModel: PlayerViewModel
 
+    private var renderingJob: Job? = null
+
     init {
         lifecycleScope.launch {
             repeatOnLifecycle(State.STARTED) {
@@ -175,7 +179,8 @@ public abstract class PlayerFragment : Fragment(), ManagedPlayerState.Listener {
      * styles and inject that into the view tree.
      */
     protected open fun handleAssetUpdate(asset: RenderableAsset?, animateTransition: Boolean) {
-        lifecycleScope.launch(if (asset is SuspendableAsset<*>) Dispatchers.Default else Dispatchers.Main) {
+        renderingJob?.cancel("handling new update")
+        renderingJob = lifecycleScope.launch(if (asset is SuspendableAsset<*>) Dispatchers.Default else Dispatchers.Main) {
             whenStarted { // TODO: This'll go away when we can call a suspend version of this
                 try {
                     renderIntoPlayerCanvas(asset, animateTransition)

jvm/core/src/main/kotlin/com/intuit/playerui/core/view/View.kt

@@ -15,6 +15,8 @@ import kotlinx.serialization.builtins.nullable
 public class View internal constructor(override val node: Node) : NodeWrapper {
     public val hooks: ViewHooks by NodeSerializableField(ViewHooks.serializer())
 
+    public val initialView: Asset? by NodeSerializableField(Asset.serializer().nullable)
+
     public val lastUpdate: Asset? by NodeSerializableField(Asset.serializer().nullable)
 
     public val resolverOptions: ResolveOptions by NodeSerializableField(ResolveOptions.serializer())