Skip to content

Commit e95c008

Browse files
committed
Avoid changing Custom properties tab automatically every time filter changes
Follow-up to #3719 The previous behavior was predicated on: - Allowing a single custom property filter - Allowing breaking down only by the chosen custom property filter Now these restrictions are removed the previous auto-switching just becomes annoying
1 parent 1cb7982 commit e95c008

File tree

1 file changed

+1
-5
lines changed
  • assets/js/dashboard/stats/behaviours

1 file changed

+1
-5
lines changed

assets/js/dashboard/stats/behaviours/props.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { useCallback, useState, useEffect } from "react";
1+
import React, { useCallback, useState } from "react"
22
import ListReport from "../reports/list";
33
import Combobox from '../../components/combobox'
44
import * as api from '../../api'
@@ -15,10 +15,6 @@ export default function Properties(props) {
1515

1616
const [propKey, setPropKey] = useState(choosePropKey())
1717

18-
useEffect(() => {
19-
setPropKey(choosePropKey())
20-
}, [query.filters.goal, query.filters.props])
21-
2218
function singleGoalFilterApplied() {
2319
const goalFilter = query.filters.goal
2420
if (goalFilter) {

0 commit comments

Comments
 (0)