Replace all pending underscore flags in the code to dashed ones

Signed-off-by: Rohit Nayak <[email protected]>

Author: rohit-nayak-ps

go/cmd/vtbackup/cli/vtbackup.go

@@ -467,7 +467,7 @@ func takeBackup(ctx, backgroundCtx context.Context, topoServer *topo.Server, bac
 	case mysqlctl.ErrNoBackup:
 		// There is no backup found, but we may be taking the initial backup of a shard
 		if !allowFirstBackup {
-			return fmt.Errorf("no backup found; not starting up empty since --initial_backup flag was not enabled")
+			return fmt.Errorf("no backup found; not starting up empty since --initial-backup flag was not enabled")
 		}
 		restorePos = replication.Position{}
 	default:
@@ -854,14 +854,14 @@ func shouldBackup(ctx context.Context, topoServer *topo.Server, backupStorage ba
 
 	// We need at least one backup so we can restore first, unless the user explicitly says we don't
 	if len(backups) == 0 && !allowFirstBackup {
-		return false, fmt.Errorf("no existing backups to restore from; backup is not possible since --initial_backup flag was not enabled")
+		return false, fmt.Errorf("no existing backups to restore from; backup is not possible since --initial-backup flag was not enabled")
 	}
 	if lastBackup == nil {
 		if allowFirstBackup {
 			// There's no complete backup, but we were told to take one from scratch anyway.
 			return true, nil
 		}
-		return false, fmt.Errorf("no complete backups to restore from; backup is not possible since --initial_backup flag was not enabled")
+		return false, fmt.Errorf("no complete backups to restore from; backup is not possible since --initial-backup flag was not enabled")
 	}
 
 	// Has it been long enough since the last complete backup to need a new one?

go/cmd/vtclient/cli/vtclient.go

@@ -72,7 +72,7 @@ For query bound variables, we assume place-holders in the query string
 in the form of :v1, :v2, etc.`,
 		Example: `vtclient --server vtgate:15991 "SELECT * FROM messages"
 
-vtclient --server vtgate:15991 --target '@primary' --bind_variables '[ 12345, 1, "msg 12345" ]' "INSERT INTO messages (page,time_created_ns,message) VALUES (:v1, :v2, :v3)"`,
+vtclient --server vtgate:15991 --target '@primary' --bind-variables '[ 12345, 1, "msg 12345" ]' "INSERT INTO messages (page,time_created_ns,message) VALUES (:v1, :v2, :v3)"`,
 		Args:    cobra.ExactArgs(1),
 		Version: servenv.AppVersion.String(),
 		RunE:    run,

go/cmd/vtcombo/cli/main.go

@@ -114,7 +114,7 @@ func init() {
 	Main.Flags().StringVar(&vschemaPersistenceDir, "vschema-persistence-dir", vschemaPersistenceDir, "If set, per-keyspace vschema will be persisted in this directory "+
 		"and reloaded into the in-memory topology server across restarts. Bookkeeping is performed using a simple watcher goroutine. "+
 		"This is useful when running vtcombo as an application development container (e.g. vttestserver) where you want to keep the same "+
-		"vschema even if developer's machine reboots. This works in tandem with vttestserver's --persistent_mode flag. Needless to say, "+
+		"vschema even if developer's machine reboots. This works in tandem with vttestserver's --persistent-mode flag. Needless to say, "+
 		"this is neither a perfect nor a production solution for vschema persistence. Consider using the --external-topo-server flag if "+
 		"you require a more complete solution. This flag is ignored if --external-topo-server is set.")
 

go/cmd/vtctldclient/command/legacy_shim.go

@@ -71,8 +71,8 @@ LegacyVtctlCommand -- help # displays help for supported legacy vtctl commands
 # before the first flag argument, like in the first example. The double dash may
 # be used, however, at any point after the "LegacyVtctlCommand" string, as in
 # the second example.
-LegacyVtctlCommand AddCellInfo -- --server_address "localhost:1234" --root "/vitess/cell1"
-LegacyVtctlCommand -- AddCellInfo --server_address "localhost:5678" --root "/vitess/cell1"`),
+LegacyVtctlCommand AddCellInfo -- --server-address "localhost:1234" --root "/vitess/cell1"
+LegacyVtctlCommand -- AddCellInfo --server-address "localhost:5678" --root "/vitess/cell1"`),
 	}
 )
 

go/cmd/vtctldclient/command/vreplication/common/cancel.go

@@ -70,7 +70,7 @@ func commandCancel(cmd *cobra.Command, args []string) error {
 	resp, err := GetClient().WorkflowDelete(GetCommandCtx(), req)
 	if err != nil {
 		if grpcerr, ok := status.FromError(err); ok && (grpcerr.Code() == codes.DeadlineExceeded) {
-			return fmt.Errorf("Cancel action timed out. Please try again and the work will pick back up where it left off. Note that you can control the timeout using the --action_timeout flag and the delete batch size with --delete-batch-size.")
+			return fmt.Errorf("Cancel action timed out. Please try again and the work will pick back up where it left off. Note that you can control the timeout using the --action-timeout flag and the delete batch size with --delete-batch-size.")
 		}
 		return err
 	}

go/cmd/vtgate/cli/cli.go

@@ -65,7 +65,7 @@ var (
 	--grpc-port 15991 \
 	--mysql-server-port 15306 \
 	--cell test \
-	--cells_to_watch test \
+	--cells-to-watch test \
 	--tablet-types-to-wait PRIMARY,REPLICA \
 	--service-map 'grpc-vtgateservice' \
 	--pid-file $VTDATAROOT/tmp/vtgate.pid \

go/cmd/vttestserver/cli/main.go

@@ -150,7 +150,7 @@ func New() (cmd *cobra.Command) {
 			" random data (--initialize-with-random-data option) will only run during"+
 			" cluster startup if the data directory does not already exist. "+
 			" Changes to VSchema are persisted across cluster restarts using a simple"+
-			" watcher if the --data_dir argument is specified.")
+			" watcher if the --data-dir argument is specified.")
 
 	utils.SetFlagBoolVar(cmd.Flags(), &doSeed, "initialize-with-random-data", false,
 		"If this flag is each table-shard will be initialized"+

go/flags/endtoend/vtclient.txt

@@ -9,7 +9,7 @@ Usage:
 Examples:
 vtclient --server vtgate:15991 "SELECT * FROM messages"
 
-vtclient --server vtgate:15991 --target '@primary' --bind_variables '[ 12345, 1, "msg 12345" ]' "INSERT INTO messages (page,time_created_ns,message) VALUES (:v1, :v2, :v3)"
+vtclient --server vtgate:15991 --target '@primary' --bind-variables '[ 12345, 1, "msg 12345" ]' "INSERT INTO messages (page,time_created_ns,message) VALUES (:v1, :v2, :v3)"
 
 Flags:
       --alsologtostderr                                             log to standard error as well as files

go/flags/endtoend/vtcombo.txt

@@ -24,7 +24,7 @@ Flags:
       --binlog-in-memory-decompressor-max-size uint                      This value sets the uncompressed transaction payload size at which we switch from in-memory buffer based decompression to the slower streaming mode. (default 134217728)
       --binlog-player-protocol string                                    the protocol to download binlogs from a vttablet (default "grpc")
       --buffer-drain-concurrency int                                     Maximum number of requests retried simultaneously. More concurrency will increase the load on the PRIMARY vttablet when draining the buffer. (default 1)
-      --buffer-keyspace-shards string                                    If not empty, limit buffering to these entries (comma separated). Entry format: keyspace or keyspace/shard. Requires --enable_buffer=true.
+      --buffer-keyspace-shards string                                    If not empty, limit buffering to these entries (comma separated). Entry format: keyspace or keyspace/shard. Requires --enable-buffer=true.
       --buffer-max-failover-duration duration                            Stop buffering completely if a failover takes longer than this duration. (default 20s)
       --buffer-min-time-between-failovers duration                       Minimum time between the end of a failover and the start of the next one (tracked per shard). Faster consecutive failovers will not trigger buffering. (default 1m0s)
       --buffer-size int                                                  Maximum number of buffered requests in flight (across all ongoing failovers). (default 1000)
@@ -420,7 +420,7 @@ Flags:
       --vreplication-retry-delay duration                                delay before retrying a failed workflow event in the replication phase (default 5s)
       --vreplication-store-compressed-gtid                               Store compressed gtids in the pos column of the sidecar database's vreplication table
       --vschema-ddl-authorized-users string                              List of users authorized to execute vschema ddl operations, or '%' to allow all users.
-      --vschema-persistence-dir string                                   If set, per-keyspace vschema will be persisted in this directory and reloaded into the in-memory topology server across restarts. Bookkeeping is performed using a simple watcher goroutine. This is useful when running vtcombo as an application development container (e.g. vttestserver) where you want to keep the same vschema even if developer's machine reboots. This works in tandem with vttestserver's --persistent_mode flag. Needless to say, this is neither a perfect nor a production solution for vschema persistence. Consider using the --external-topo-server flag if you require a more complete solution. This flag is ignored if --external-topo-server is set.
+      --vschema-persistence-dir string                                   If set, per-keyspace vschema will be persisted in this directory and reloaded into the in-memory topology server across restarts. Bookkeeping is performed using a simple watcher goroutine. This is useful when running vtcombo as an application development container (e.g. vttestserver) where you want to keep the same vschema even if developer's machine reboots. This works in tandem with vttestserver's --persistent-mode flag. Needless to say, this is neither a perfect nor a production solution for vschema persistence. Consider using the --external-topo-server flag if you require a more complete solution. This flag is ignored if --external-topo-server is set.
       --vstream-binlog-rotation-threshold int                            Byte size at which a VStreamer will attempt to rotate the source's open binary log before starting a GTID snapshot based stream (e.g. a ResultStreamer or RowStreamer) (default 67108864)
       --vstream-dynamic-packet-size                                      Enable dynamic packet sizing for vstreamers. This will adjust the packet size in vreplication workflows to improve performance. (default true)
       --vstream-packet-size int                                          Suggested packet size for vstreamers. The actual packet size may be more or less than this amount. (default 250000)

go/flags/endtoend/vtctld.txt

@@ -16,7 +16,7 @@ vtctld \
 	--topo-global-root /vitess/ \
 	--service-map 'grpc-vtctl,grpc-vtctld' \
 	--backup-storage-implementation file \
-	--file_backup_storage_root $VTDATAROOT/backups \
+	--file-backup-storage-root $VTDATAROOT/backups \
 	--port 15000 \
 	--grpc-port 15999