Avoid setLevel in child when possible (#2271)

mcollina · web-flow · commit d6114a61b450 · 2025-09-04T06:17:27.000-07:00
Signed-off-by: Matteo Collina &lt;hello@matteocollina.com&gt;
diff --git a/lib/proto.js b/lib/proto.js
@@ -147,8 +147,10 @@ function child (bindings, options) {
   }
 
   instance[chindingsSym] = asChindings(instance, bindings)
-  const childLevel = options.level || this.level
-  instance[setLevelSym](childLevel)
+  if ((options.level !== undefined && options.level !== this.level) || options.hasOwnProperty('customLevels')) {
+    const childLevel = options.level || this.level
+    instance[setLevelSym](childLevel)
+  }
   this.onChild(instance)
   return instance
 }

Original file line number	Diff line number	Diff line change
`@@ -147,8 +147,10 @@ function child (bindings, options) {`
`147`	`147`	`}`
`148`	`148`
`149`	`149`	`instance[chindingsSym] = asChindings(instance, bindings)`
`150`		`- const childLevel = options.level \|\| this.level`
`151`		`- instance[setLevelSym](childLevel)`
	`150`	`+ if ((options.level !== undefined && options.level !== this.level) \|\| options.hasOwnProperty('customLevels')) {`
	`151`	`+ const childLevel = options.level \|\| this.level`
	`152`	`+ instance[setLevelSym](childLevel)`
	`153`	`+ }`
`152`	`154`	`this.onChild(instance)`
`153`	`155`	`return instance`
`154`	`156`	`}`