Remove Pytype integration

See google/pytype#1925.

Author: phst

.bazelrc

@@ -29,10 +29,6 @@ build:windows --copt='/external:W0' --host_copt='/external:W0'
 # Run Pylint by default.
 build --aspects='//dev:pylint.bzl%pylint'
 
-# Run Pytype on platforms where it’s supported.
-build:linux --aspects='//dev:pytype.bzl%pytype'
-build:macos --aspects='//dev:pytype.bzl%pytype'
-
 # Run Mypy by default.
 build --aspects='//dev:mypy.bzl%mypy'
 build --output_groups='+mypy'

dev/BUILD

@@ -59,10 +59,9 @@ compile_pip_requirements(
     requirements_in = "requirements.txt",
     requirements_txt = ":requirements_lock",
     tags = [
-        # Don’t try to run Pylint, Pytype, or Mypy.  This target doesn’t contain
-        # any of our source files.
+        # Don’t try to run Pylint or Mypy.  This target doesn’t contain any of
+        # our source files.
         "no-pylint",
-        "no-pytype",
         "no-mypy",
     ],
 )
@@ -82,13 +81,7 @@ py_binary(
     main = "check_python.py",
     python_version = "3.12",
     visibility = ["//private:__pkg__"],
-    deps = [requirement("pylint")] + select({
-        # Pytype doesn’t work on Windows, so don’t build it when running
-        # “bazel build //...”.
-        "@platforms//os:linux": [requirement("pytype")],
-        "@platforms//os:macos": [requirement("pytype")],
-        "//conditions:default": [],
-    }),
+    deps = [requirement("pylint")],
 )
 
 nogo(
@@ -135,15 +128,6 @@ bzl_library(
     ],
 )
 
-bzl_library(
-    name = "pytype",
-    srcs = ["pytype.bzl"],
-    deps = [
-        ":check_python_bzl",
-        "@rules_python//python:py_info_bzl",
-    ],
-)
-
 # keep
 bzl_library(
     name = "check_python_bzl",

dev/check_python.bzl

@@ -26,13 +26,13 @@ def check_python(
         additional_inputs = [],
         mnemonic,
         progress_message):
-    """Run Pylint or Pytype on Python source files.
+    """Run Pylint on Python source files.
 
     Args:
       ctx: the rule context
       info: a PyInfo object
       stem: base name of files that will be generated
-      program: name of the program to run, either "pylint" or "pytype"
+      program: name of the program to run, must be "pylint"
       program_args: additional arguments for the program, either an Args object
           or None
       additional_inputs: list of additional input files for the program,

dev/check_python.py

@@ -12,14 +12,13 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-"""Runs Pylint and Pytype."""
+"""Runs Pylint."""
 
 import argparse
 import json
 import os
 import os.path
 import pathlib
-import platform
 import shutil
 import sys
 import subprocess
@@ -37,16 +36,15 @@ def main() -> None:
     subparsers = parser.add_subparsers(required=True, dest='program')
     pylint = subparsers.add_parser('pylint', allow_abbrev=False)
     pylint.add_argument('--pylintrc', type=pathlib.Path, required=True)
-    subparsers.add_parser('pytype', allow_abbrev=False)
     args = parser.parse_args()
     workspace_name = args.workspace_name
     dirs = [d for d in sys.path if os.path.basename(d) == workspace_name]
     if len(dirs) != 1:
         raise ValueError(f'no unique workspace directory: {dirs}')
     module_space = pathlib.Path(dirs[0]).parent
     module_space_stat = module_space.stat()
-    # Set a fake PYTHONPATH so that Pylint and Pytype can find imports for the
-    # main and external repositories.
+    # Set a fake PYTHONPATH so that Pylint can find imports for the main and
+    # external repositories.
     params = json.loads(args.params.read_text(encoding='utf-8'))
     srcs = []
     tempdir = pathlib.Path(tempfile.mkdtemp(prefix='pylint-'))
@@ -67,11 +65,6 @@ def main() -> None:
             (path / '__init__.py').touch()
     srcset = frozenset(srcs)
     repository_path = [str(tempdir / d) for d in args.path]
-    # Pytype wants a Python binary available under the name “python”.  See the
-    # function pytype.tools.environment.check_python_exe_or_die.
-    bindir = tempdir / 'bin'
-    bindir.mkdir()
-    (bindir / 'python').symlink_to(sys.executable)
     orig_path = []
     for entry in sys.path:
         try:
@@ -87,7 +80,6 @@ def main() -> None:
             pass  # ignore nonexisting entries
     cwd = tempdir / workspace_name
     env = dict(os.environ,
-               PATH=os.pathsep.join([str(bindir)] + os.get_exec_path()),
                PYTHONPATH=os.pathsep.join(orig_path + repository_path))
     if args.program == 'pylint':
         result = subprocess.run(
@@ -102,18 +94,6 @@ def main() -> None:
         if result.returncode:
             print(result.stdout)
             sys.exit(result.returncode)
-    if platform.system() != 'Windows' and args.program == 'pytype':
-        result = subprocess.run(
-            [sys.executable, '-m', 'pytype',
-             '--pythonpath=' + os.pathsep.join(repository_path),
-             '--no-cache', '--'] + [str(file.relative_to(cwd))
-                                    for file in sorted(srcset)],
-            check=False, cwd=cwd, env=env,
-            stdout=subprocess.PIPE, stderr=subprocess.STDOUT,
-            encoding='utf-8', errors='backslashreplace')
-        if result.returncode:
-            print(result.stdout)
-            sys.exit(result.returncode)
     # Only clean up the workspace if we exited successfully, to help with
     # debugging.
     shutil.rmtree(tempdir)