non-empty-string can still contain falsy strings as individual characters

Author: ondrejmirtes

src/Type/Accessory/AccessoryNonFalsyStringType.php

@@ -112,10 +112,6 @@ public function getOffsetValueType(Type $offsetType): Type
 			return new ErrorType();
 		}
 
-		if ((new ConstantIntegerType(0))->isSuperTypeOf($offsetType)->yes()) {
-			return new IntersectionType([new StringType(), new AccessoryNonFalsyStringType()]);
-		}
-
 		return new StringType();
 	}
 

tests/PHPStan/Rules/Comparison/StrictComparisonOfDifferentTypesRuleTest.php

@@ -601,4 +601,10 @@ public function testBug2851b(): void
 		$this->analyse([__DIR__ . '/data/bug-2851b.php'], []);
 	}
 
+	public function testBug8158(): void
+	{
+		$this->checkAlwaysTrueStrictComparison = true;
+		$this->analyse([__DIR__ . '/data/bug-8158.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Comparison/data/bug-8158.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace Bug8158;
+
+function phone_number_starts_with_zero(string $phone_number): bool
+{
+	return $phone_number && $phone_number[0] === '0';
+}