Skip to content

Commit 3a593a2

Browse files
authored
Fix CTS memory leaks (#519)
1 parent 224f4aa commit 3a593a2

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/Akka.Persistence.Azure/Journal/AzureTableStorageJournal.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,7 @@ private async Task InitCloudStorage(int remainingTries, CancellationToken cancel
623623
{
624624
var tableClient = _tableServiceClient.GetTableClient(_settings.TableName);
625625

626-
var cts = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
626+
using var cts = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
627627
cts.CancelAfter(_settings.ConnectTimeout);
628628
using (cts)
629629
{

src/Akka.Persistence.Azure/Snapshot/AzureBlobSnapshotStore.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ private async Task<BlobContainerClient> InitCloudStorage(int remainingTries, Can
100100
{
101101
var blobClient = _serviceClient.GetBlobContainerClient(_settings.ContainerName);
102102

103-
var cts = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
103+
using var cts = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
104104
cts.CancelAfter(_settings.ConnectTimeout);
105105
using (cts)
106106
{
@@ -179,7 +179,7 @@ protected override void PostStop()
179179
SnapshotSelectionCriteria criteria,
180180
CancellationToken cancellationToken)
181181
{
182-
var cts = CancellationTokenSource.CreateLinkedTokenSource(_shutdownCts.Token, cancellationToken);
182+
using var cts = CancellationTokenSource.CreateLinkedTokenSource(_shutdownCts.Token, cancellationToken);
183183
cts.CancelAfter(_settings.RequestTimeout);
184184
using(cts)
185185
{
@@ -231,7 +231,7 @@ protected override async Task SaveAsync(SnapshotMetadata metadata, object snapsh
231231
var blobClient = Container.GetBlockBlobClient(metadata.ToSnapshotBlobId(_settings.Folders));
232232
var snapshotData = _serialization.SnapshotToBytes(new Serialization.Snapshot(snapshot));
233233

234-
var cts = CancellationTokenSource.CreateLinkedTokenSource(_shutdownCts.Token, cancellationToken);
234+
using var cts = CancellationTokenSource.CreateLinkedTokenSource(_shutdownCts.Token, cancellationToken);
235235
cts.CancelAfter(_settings.RequestTimeout);
236236
using (cts)
237237
{
@@ -259,7 +259,7 @@ protected override async Task DeleteAsync(SnapshotMetadata metadata, Cancellatio
259259
{
260260
var blobClient = Container.GetBlobClient(metadata.ToSnapshotBlobId(_settings.Folders));
261261

262-
var cts = CancellationTokenSource.CreateLinkedTokenSource(_shutdownCts.Token, cancellationToken);
262+
using var cts = CancellationTokenSource.CreateLinkedTokenSource(_shutdownCts.Token, cancellationToken);
263263
cts.CancelAfter(_settings.RequestTimeout);
264264
using (cts)
265265
{
@@ -283,7 +283,7 @@ protected override async Task DeleteAsync(SnapshotMetadata metadata, Cancellatio
283283

284284
protected override async Task DeleteAsync(string persistenceId, SnapshotSelectionCriteria criteria, CancellationToken cancellationToken)
285285
{
286-
var cts = CancellationTokenSource.CreateLinkedTokenSource(_shutdownCts.Token, cancellationToken);
286+
using var cts = CancellationTokenSource.CreateLinkedTokenSource(_shutdownCts.Token, cancellationToken);
287287
cts.CancelAfter(_settings.RequestTimeout);
288288
using (cts)
289289
{

0 commit comments

Comments
 (0)