update: remove datetime converters built into .net 7

Author: pdevito3

CHANGELOG.md

@@ -11,6 +11,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 * None yet!
 
+## [0.19.1] - 02/04/2023
+
+### Updates
+
+* Removed custom dateonly and timeonly json converters in facor of built in .net 7 options
+
 ## [0.19.0] - 02/04/2023
 
 ### Updates

Craftsman/Builders/ExtensionBuilders/ServiceConfigurationBuilder.cs

@@ -68,8 +68,7 @@ public static void ConfigureServices(this WebApplicationBuilder builder)
         builder.Services.AddBoundaryServices(Assembly.GetExecutingAssembly());
 
         builder.Services
-            .AddMvc(options => options.Filters.Add<ErrorHandlerFilterAttribute>())
-            .AddJsonOptions(opt => opt.JsonSerializerOptions.AddDateOnlyConverters());
+            .AddMvc(options => options.Filters.Add<ErrorHandlerFilterAttribute>());
 
         if(builder.Environment.EnvironmentName != Consts.Testing.FunctionalTestingEnvName)
         {{
@@ -105,62 +104,6 @@ private static void AddBoundaryServices(this IServiceCollection services, params
             }}
         }}
     }}
-}}
-
-// TODO these will be baked into System.Text.Json in .NET 7
-public static class DateOnlyConverterExtensions
-{{
-    public static void AddDateOnlyConverters(this JsonSerializerOptions options)
-    {{
-        options.Converters.Add(new DateOnlyConverter());
-        options.Converters.Add(new DateOnlyNullableConverter());
-    }}
-}}
-
-public class DateOnlyConverter : JsonConverter<DateOnly>
-{{
-    public override DateOnly Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
-    {{
-        if (reader.TryGetDateTime(out var dt))
-        {{
-            return DateOnly.FromDateTime(dt);
-        }};
-        var value = reader.GetString();
-        if (value == null)
-        {{
-            return default;
-        }}
-        var match = new Regex(""^(\\d\\d\\d\\d)-(\\d\\d)-(\\d\\d)(T|\\s|\\z)"").Match(value);
-        return match.Success
-            ? new DateOnly(int.Parse(match.Groups[1].Value), int.Parse(match.Groups[2].Value), int.Parse(match.Groups[3].Value))
-            : default;
-    }}
-
-    public override void Write(Utf8JsonWriter writer, DateOnly value, JsonSerializerOptions options)
-        => writer.WriteStringValue(value.ToString(""yyyy-MM-dd""));
-}}
-
-public class DateOnlyNullableConverter : JsonConverter<DateOnly?>
-{{
-    public override DateOnly? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
-    {{
-        if (reader.TryGetDateTime(out var dt))
-        {{
-            return DateOnly.FromDateTime(dt);
-        }};
-        var value = reader.GetString();
-        if (value == null)
-        {{
-            return default;
-        }}
-        var match = new Regex(""^(\\d\\d\\d\\d)-(\\d\\d)-(\\d\\d)(T|\\s|\\z)"").Match(value);
-        return match.Success
-            ? new DateOnly(int.Parse(match.Groups[1].Value), int.Parse(match.Groups[2].Value), int.Parse(match.Groups[3].Value))
-            : default;
-    }}
-
-    public override void Write(Utf8JsonWriter writer, DateOnly? value, JsonSerializerOptions options)
-        => writer.WriteStringValue(value?.ToString(""yyyy-MM-dd""));
 }}";
     }
 }

Craftsman/Builders/Tests/Utilities/HttpClientExtensionsBuilder.cs

@@ -58,14 +58,12 @@ public static async Task<HttpResponseMessage> DeleteRequestAsync(this HttpClient
     public static async Task<HttpResponseMessage> PostJsonRequestAsync(this HttpClient client, string url, object value)
     {{
         var options = new JsonSerializerOptions();
-        options.AddDateOnlyConverters();
         return await client.PostAsJsonAsync(url, value, options).ConfigureAwait(false);
     }}
 
     public static async Task<HttpResponseMessage> PutJsonRequestAsync(this HttpClient client, string url, object value)
     {{
         var options = new JsonSerializerOptions();
-        options.AddDateOnlyConverters();
         return await client.PutAsJsonAsync(url, value, options).ConfigureAwait(false);
     }}
 }}";