chore: fix lint warnings for default exports, unused imports, unused err in catch (#12666)

Fix various lint warnings in payload package. 

387 warnings -> 215 warnings

- Migrate (most) default exports to named
- Remove unused imports
- Rename unused errors in catch statements to `ignore`

Author: denolfe

packages/payload/src/admin/RichText.ts

@@ -1,13 +1,9 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import type { GenericLanguages, I18n } from '@payloadcms/translations'
 import type { JSONSchema4 } from 'json-schema'
 
 import type { SanitizedCollectionConfig, TypeWithID } from '../collections/config/types.js'
-import type {
-  Config,
-  ImportMapGenerators,
-  PayloadComponent,
-  SanitizedConfig,
-} from '../config/types.js'
+import type { ImportMapGenerators, PayloadComponent, SanitizedConfig } from '../config/types.js'
 import type { ValidationFieldError } from '../errors/ValidationError.js'
 import type {
   FieldAffectingData,
@@ -22,8 +18,11 @@ import type { RichTextFieldClientProps, RichTextFieldServerProps } from './field
 import type { FieldDiffClientProps, FieldDiffServerProps, FieldSchemaMap } from './types.js'
 
 export type AfterReadRichTextHookArgs<
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   TData extends TypeWithID = any,
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   TValue = any,
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   TSiblingData = any,
 > = {
   currentDepth?: number
@@ -58,6 +57,7 @@ export type AfterReadRichTextHookArgs<
 export type AfterChangeRichTextHookArgs<
   TData extends TypeWithID = any,
   TValue = any,
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   TSiblingData = any,
 > = {
   /** A string relating to which operation the field type is currently executing within. */
@@ -73,6 +73,7 @@ export type AfterChangeRichTextHookArgs<
 export type BeforeValidateRichTextHookArgs<
   TData extends TypeWithID = any,
   TValue = any,
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   TSiblingData = any,
 > = {
   /** A string relating to which operation the field type is currently executing within. */
@@ -87,6 +88,7 @@ export type BeforeValidateRichTextHookArgs<
 export type BeforeChangeRichTextHookArgs<
   TData extends TypeWithID = any,
   TValue = any,
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   TSiblingData = any,
 > = {
   /**

packages/payload/src/admin/fields/Select.ts

@@ -1,8 +1,7 @@
 import type { MarkOptional } from 'ts-essentials'
 
-import type { Option, SelectField, SelectFieldClient } from '../../fields/config/types.js'
+import type { SelectField, SelectFieldClient } from '../../fields/config/types.js'
 import type { SelectFieldValidation } from '../../fields/validations.js'
-import type { PayloadRequest } from '../../types/index.js'
 import type { FieldErrorClientComponent, FieldErrorServerComponent } from '../forms/Error.js'
 import type {
   ClientFieldBase,

packages/payload/src/admin/forms/Diff.ts

@@ -5,7 +5,6 @@ import type {
   ClientFieldWithOptionalType,
   PayloadRequest,
   SanitizedFieldPermissions,
-  TypedLocale,
 } from '../../index.js'
 
 export type VersionTab = {

packages/payload/src/auth/operations/login.ts

@@ -18,7 +18,7 @@ import {
 import { afterRead } from '../../fields/hooks/afterRead/index.js'
 import { Forbidden } from '../../index.js'
 import { killTransaction } from '../../utilities/killTransaction.js'
-import sanitizeInternalFields from '../../utilities/sanitizeInternalFields.js'
+import { sanitizeInternalFields } from '../../utilities/sanitizeInternalFields.js'
 import { getFieldsToSign } from '../getFieldsToSign.js'
 import { getLoginOptions } from '../getLoginOptions.js'
 import { isUserLocked } from '../isUserLocked.js'

packages/payload/src/auth/strategies/apiKey.ts

@@ -52,7 +52,7 @@ export const APIKeyAuthentication =
             user: user as User,
           }
         }
-      } catch (err) {
+      } catch (ignore) {
         return { user: null }
       }
     }

packages/payload/src/auth/strategies/jwt.ts

@@ -1,7 +1,7 @@
 import { jwtVerify } from 'jose'
 
 import type { Payload, Where } from '../../types/index.js'
-import type { AuthStrategyFunction, AuthStrategyResult, User } from '../index.js'
+import type { AuthStrategyFunction, AuthStrategyResult } from '../index.js'
 
 import { extractJWT } from '../extractJWT.js'
 

packages/payload/src/auth/strategies/local/authenticate.ts

@@ -34,7 +34,7 @@ export const authenticateLocalStrategy = async ({ doc, password }: Args): Promis
     }
 
     return null
-  } catch (err) {
+  } catch (ignore) {
     return null
   }
 }

packages/payload/src/bin/generateImportMap/iterateConfig.ts

@@ -1,4 +1,3 @@
-import type { AdminViewConfig } from '../../admin/views/index.js'
 import type { SanitizedConfig } from '../../config/types.js'
 import type { AddToImportMap, Imports, InternalImportMap } from './index.js'
 

packages/payload/src/bin/index.ts

@@ -5,8 +5,6 @@ import minimist from 'minimist'
 import { pathToFileURL } from 'node:url'
 import path from 'path'
 
-import type { BinScript } from '../config/types.js'
-
 import { findConfig } from '../config/find.js'
 import payload, { getPayload } from '../index.js'
 import { generateImportMap } from './generateImportMap/index.js'

packages/payload/src/collections/config/sanitize.ts

@@ -11,12 +11,12 @@ import { getBaseAuthFields } from '../../auth/getAuthFields.js'
 import { TimestampsRequired } from '../../errors/TimestampsRequired.js'
 import { sanitizeFields } from '../../fields/config/sanitize.js'
 import { fieldAffectsData } from '../../fields/config/types.js'
-import mergeBaseFields from '../../fields/mergeBaseFields.js'
+import { mergeBaseFields } from '../../fields/mergeBaseFields.js'
 import { uploadCollectionEndpoints } from '../../uploads/endpoints/index.js'
 import { getBaseUploadFields } from '../../uploads/getBaseFields.js'
 import { flattenAllFields } from '../../utilities/flattenAllFields.js'
 import { formatLabels } from '../../utilities/formatLabels.js'
-import baseVersionFields from '../../versions/baseFields.js'
+import { baseVersionFields } from '../../versions/baseFields.js'
 import { versionDefaults } from '../../versions/defaults.js'
 import { defaultCollectionEndpoints } from '../endpoints/index.js'
 import {