Can I request a code-review on Joplin-desktop?

[wind0204]

Describe the bug

It seems atomic works only for the first file.
I'm pretty sure it's not a bug of chokidar but Joplin; and the problem is I have 0 proficiency in typescript so can't debug it.
Can you please kindly take a look at the application of chokidar in Joplin?
laurent22/joplin#11595

The buggy function is this one: https://github.com/laurent22/joplin/blob/6048f9613c8b906a9073de77a70555f05d04fc49/packages/lib/services/ExternalEditWatcher.ts#L90

Versions (please complete the following information):

• Chokidar version [v3.6.0]
• Node version [18+]
• OS version: [Ubuntu 24.04]

To Reproduce:

The buggy function is this one: https://github.com/laurent22/joplin/blob/6048f9613c8b906a9073de77a70555f05d04fc49/packages/lib/services/ExternalEditWatcher.ts#L90

I guess the default value of atomic option should be true according to the code in which useFsEvents and usePolling seem to be false

And vim and SSD on my system are quick so I don't think they take much time to write a few lines of text. So I doubt I need change of the "grace period"

It's interesting that only the first note you have ever started watching after launch of Joplin is immune to the bug.

Expected behavior
Not only the first note, but other notes should have the atomic working.

Additional context
I'm sorry but it seems the maintainer of Joplin is very busy... so I came here to ask for help! Thank you for reading the request..

[43081j]

im going to convert this to a discussion since it makes more sense there than being an "issue" of chokidar

your usage looks fine at a glance but i doubt paul or I will have enough time to review it properly any time soon. maybe someone else will eventually respond to the discussion though

if you can make a minimal reproduction, some script that just sets a watcher up and shows it only firing for the first file, that will make it more likely someone can investigate