Skip to content

feat(simple list): removed deprecated prop #8132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2022
Merged

feat(simple list): removed deprecated prop #8132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/react-core/src/components/SimpleList/SimpleListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ export interface SimpleListItemProps {
componentProps?: any;
/** Indicates if the link is current/highlighted */
isActive?: boolean;
/** @deprecated please use isActive instead */
isCurrent?: boolean;
/** OnClick callback for the SimpleList item */
onClick?: (event: React.MouseEvent | React.ChangeEvent) => void;
/** Type of button SimpleList item */
Expand All @@ -35,7 +33,6 @@ export class SimpleListItem extends React.Component<SimpleListItemProps> {
children: null,
className: '',
isActive: false,
isCurrent: false,
component: 'button',
componentClassName: '',
type: 'button',
Expand All @@ -46,7 +43,6 @@ export class SimpleListItem extends React.Component<SimpleListItemProps> {
render() {
const {
children,
isCurrent,
isActive,
className,
component: Component,
Expand All @@ -64,7 +60,7 @@ export class SimpleListItem extends React.Component<SimpleListItemProps> {
{({ currentRef, updateCurrentRef, isControlled }) => {
const isButton = Component === 'button';
const isCurrentItem =
this.ref && currentRef && isControlled ? currentRef.current === this.ref.current : isActive || isCurrent;
this.ref && currentRef && isControlled ? currentRef.current === this.ref.current : isActive;

const additionalComponentProps = isButton
? {
Expand Down