Skip to content

Commit ac0c0b9

Browse files
bennypowerszeroedin
andcommitted
feat(tabs)!: migrate pfe-tabs to lit
**Features** - add CSS parts **Fixes** - add {{version}} to element classes - rename `pfeEvent` to `deprecatedCustomEvent` **Tests** - e2e tests with page object model - build demo with optional shadowroot **Docs** - add CSS to demo page for tabs (#1835) - rearrange docs urls - inline docs - refactor docs page - add changeset - use pfe-styles Co-Authored-By: Steven Spriggs <[email protected]>
1 parent 088a470 commit ac0c0b9

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+2142
-6758
lines changed

.changeset/tabs.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
---
2+
"@patternfly/pfe-tabs": major
3+
---
4+
5+
## 🔥 Migrate to Lit
6+
7+
This release migrates `<pfe-tabs>` to LitElement.
8+
9+
### NEW: CSS Shadow Parts!
10+
- Adds `tabs` and `panels` CSS parts to `<pfe-tabs>`
11+
- Adds `container` CSS part to `<pfe-tab-panel>`
12+
13+
### Breaking Changes
14+
- Initial render is now [asynchronous](https://lit.dev/docs/components/lifecycle/#reactive-update-cycle).
15+
If your code assumes that shadow DOM is ready once the element is constructed, update it to `await element.updateComplete`
16+
17+
See [docs](https://patternflyelements.org/components/tabs/) for more info

elements/pfe-tabs/.npmignore

Lines changed: 0 additions & 1 deletion
This file was deleted.

elements/pfe-tabs/README.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,6 @@ below, selecting "Tab 2" will update the URL as follows: `?my-tabs=tab2`.
103103
</pfe-tabs>
104104
```
105105

106-
*Note:* This feature is not supported in IE11.
107-
108106
## Using the URL to open a specific tab
109107

110108
By default, `pfe-tabs` will read the URL and look for a query string parameter
@@ -134,8 +132,6 @@ In the event that a tab with the supplied id in the URL does not exist,
134132
`pfe-tabs` will fall back to the `selected-index` attribute if one is supplied
135133
in the markup, or the first tab if `selected-index` is not provided.
136134

137-
*Note:* This feature is not supported in IE11.
138-
139135
## Events
140136

141137
### pfe-tabs:shown-tab
@@ -183,7 +179,7 @@ Fires when a selected tab is no longer the selected tab. The `event.detail.tab`
183179
| `--pfe-tabs__panel--BorderRight` | | 0 |
184180
| `--pfe-tabs__panel--BorderBottom` | | 0 |
185181
| `--pfe-tabs__panel--BorderLeft` | | 0 |
186-
182+
187183
## Test
188184

189185
npm run test
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import { pfeCustomElementsManifestConfig } from '@patternfly/pfe-tools/custom-elements-manifest.js';
2+
3+
export default pfeCustomElementsManifestConfig({
4+
globs: ['pfe-*.ts'],
5+
});

elements/pfe-tabs/demo/all-combos.css

Lines changed: 0 additions & 158 deletions
This file was deleted.

0 commit comments

Comments
 (0)