Update deprecated usage (#937)

* Update bigint.rs

* Apply suggestion from @bkchr

* Apply rustc suggestions

* Fix Test macOS-latest

* Apply rustc suggestions

* Fix more deprecation

---------

Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Serban Iorga <[email protected]>

Author: 3 people

.github/workflows/ci.yml

@@ -50,8 +50,8 @@ jobs:
       - name: Workaround macOS Clang
         if: ${{ runner.os == 'macOS' }}
         run: | 
-          brew install llvm@20
-          brew link llvm@20
+          brew install llvm@15
+          brew link llvm@15
 
       - name: Rust Cache
         uses: Swatinem/rust-cache@98c8021b550208e191a6a3145459bfc9fb29c4c0 # v2.8.0

bounded-collections/src/bounded_btree_map.rs

@@ -213,7 +213,7 @@ where
 	/// Gets a mutable iterator over the entries of the map, sorted by key.
 	///
 	/// See [`BTreeMap::iter_mut`] for more information.
-	pub fn iter_mut(&mut self) -> alloc::collections::btree_map::IterMut<K, V> {
+	pub fn iter_mut(&mut self) -> alloc::collections::btree_map::IterMut<'_, K, V> {
 		self.0.iter_mut()
 	}
 

bounded-collections/src/bounded_vec.rs

@@ -641,7 +641,7 @@ impl<T, S: Get<u32>> BoundedVec<T, S> {
 
 impl<T, S> BoundedVec<T, S> {
 	/// Return a [`BoundedSlice`] with the content and bound of [`Self`].
-	pub fn as_bounded_slice(&self) -> BoundedSlice<T, S> {
+	pub fn as_bounded_slice(&self) -> BoundedSlice<'_, T, S> {
 		BoundedSlice(&self.0[..], PhantomData::default())
 	}
 }

fixed-hash/benches/cmp.rs

@@ -8,9 +8,9 @@
 
 //! Benchmarks for fixed-hash cmp implementation.
 
-use criterion::{black_box, criterion_group, criterion_main, BenchmarkId, Criterion};
-
+use criterion::{criterion_group, criterion_main, BenchmarkId, Criterion};
 use fixed_hash::construct_fixed_hash;
+use std::hint::black_box;
 
 construct_fixed_hash! { pub struct H256(32); }
 

keccak-hash/benches/keccak_256.rs

@@ -6,8 +6,9 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-use criterion::{black_box, criterion_group, criterion_main, Criterion};
+use criterion::{criterion_group, criterion_main, Criterion};
 use keccak_hash::keccak;
+use std::hint::black_box;
 
 criterion_group!(keccak_256, keccak_256_with_empty_input, keccak_256_with_typical_input, keccak_256_with_large_input,);
 criterion_main!(keccak_256);

kvdb-rocksdb/benches/bench_read_perf.rs

@@ -26,9 +26,10 @@ use std::{
 };
 
 use alloc_counter::{count_alloc, AllocCounterSystem};
-use criterion::{black_box, criterion_group, criterion_main, Criterion};
+use criterion::{criterion_group, criterion_main, Criterion};
 use ethereum_types::H256;
 use rand::{distributions::Uniform, seq::SliceRandom, Rng};
+use std::hint::black_box;
 
 use kvdb_rocksdb::{Database, DatabaseConfig};
 

primitive-types/impls/serde/benches/impl_serde.rs

@@ -12,9 +12,10 @@
 //! cargo bench
 //! ```
 
-use criterion::{black_box, criterion_group, criterion_main, BenchmarkId, Criterion};
+use criterion::{criterion_group, criterion_main, BenchmarkId, Criterion};
 use impl_serde::impl_uint_serde;
 use serde_derive::{Deserialize, Serialize};
+use std::hint::black_box;
 use uint::*;
 
 mod input;

rlp/src/rlpin.rs

@@ -297,7 +297,7 @@ impl<'a> Rlp<'a> {
 		self.at(index)?.as_list()
 	}
 
-	pub fn decoder(&self) -> BasicDecoder {
+	pub fn decoder(&self) -> BasicDecoder<'_> {
 		BasicDecoder::new(self.bytes)
 	}
 

rlp/src/stream.rs

@@ -324,7 +324,7 @@ impl RlpStream {
 		self.finished_list = should_finish;
 	}
 
-	pub fn encoder(&mut self) -> BasicEncoder {
+	pub fn encoder(&mut self) -> BasicEncoder<'_> {
 		BasicEncoder::new(self, self.start_pos)
 	}
 

uint/benches/bigint.rs

@@ -30,10 +30,10 @@ impl U256 {
 	}
 }
 
-use criterion::{black_box, Bencher, BenchmarkId, Criterion};
+use criterion::{Bencher, BenchmarkId, Criterion};
 use num_bigint::BigUint;
 use rug::{integer::Order, Integer};
-use std::str::FromStr;
+use std::{hint::black_box, str::FromStr};
 
 criterion_group!(
 	bigint,