feat: fix tx da scaling (#16558)

Solar Mithril · web-flow · commit f2d186348554 · 2025-06-03T11:01:23.000+02:00
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -507,7 +507,7 @@ op-alloy-rpc-types-engine = { version = "0.17.2", default-features = false }
 op-alloy-network = { version = "0.17.2", default-features = false }
 op-alloy-consensus = { version = "0.17.2", default-features = false }
 op-alloy-rpc-jsonrpsee = { version = "0.17.2", default-features = false }
-op-alloy-flz = { version = "0.13.0", default-features = false }
+op-alloy-flz = { version = "0.13.1", default-features = false }
 
 # misc
 aquamarine = "0.6"
diff --git a/crates/optimism/txpool/src/transaction.rs b/crates/optimism/txpool/src/transaction.rs
@@ -69,14 +69,14 @@ impl<Cons: SignedTransaction, Pooled> OpPooledTransaction<Cons, Pooled> {
         }
     }
 
-    /// Returns the estimated compressed size of a transaction in bytes scaled by 1e6.
+    /// Returns the estimated compressed size of a transaction in bytes.
     /// This value is computed based on the following formula:
-    /// `max(minTransactionSize, intercept + fastlzCoef*fastlzSize)`
+    /// `max(minTransactionSize, intercept + fastlzCoef*fastlzSize) / 1e6`
     /// Uses cached EIP-2718 encoded bytes to avoid recomputing the encoding for each estimation.
     pub fn estimated_compressed_size(&self) -> u64 {
         *self
             .estimated_tx_compressed_size
-            .get_or_init(|| op_alloy_flz::tx_estimated_size_fjord(self.encoded_2718()))
+            .get_or_init(|| op_alloy_flz::tx_estimated_size_fjord_bytes(self.encoded_2718()))
     }
 
     /// Returns lazily computed EIP-2718 encoded bytes of the transaction.

Original file line number	Diff line number	Diff line change
`@@ -69,14 +69,14 @@ impl<Cons: SignedTransaction, Pooled> OpPooledTransaction<Cons, Pooled> {`
`69`	`69`	`}`
`70`	`70`	`}`
`71`	`71`
`72`		`- /// Returns the estimated compressed size of a transaction in bytes scaled by 1e6.`
	`72`	`+ /// Returns the estimated compressed size of a transaction in bytes.`
`73`	`73`	`/// This value is computed based on the following formula:`
`74`		- /// `max(minTransactionSize, intercept + fastlzCoef*fastlzSize)`
	`74`	+ /// `max(minTransactionSize, intercept + fastlzCoef*fastlzSize) / 1e6`
`75`	`75`	`/// Uses cached EIP-2718 encoded bytes to avoid recomputing the encoding for each estimation.`
`76`	`76`	`pub fn estimated_compressed_size(&self) -> u64 {`
`77`	`77`	`*self`
`78`	`78`	`.estimated_tx_compressed_size`
`79`		`- .get_or_init(\|\| op_alloy_flz::tx_estimated_size_fjord(self.encoded_2718()))`
	`79`	`+ .get_or_init(\|\| op_alloy_flz::tx_estimated_size_fjord_bytes(self.encoded_2718()))`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`/// Returns lazily computed EIP-2718 encoded bytes of the transaction.`