Officially support using pathlib.Path for static_folder. #3579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jab
force-pushed
the
pathlib-for-static_folder
branch
2 times, most recently
from
4aac2e0 to
cd59606
Compare
* No longer causes AttributeError: 'PosixPath' object has no attribute 'rstrip'. * This was broken by e6178fe which was released in 1.1.2. * Add a regression test that now passes. See pallets#3557.
jab
force-pushed
the
pathlib-for-static_folder
branch
from
cd59606 to
7ba35c4
Compare
pgjones
approved these changes
Jul 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer causes
AttributeError: 'PosixPath' object has no attribute 'rstrip'.This was broken by e6178fe which was released in 1.1.2.
Add a regression test that now passes.
See #3557.
(That issue was repurposed for migrating to pathlib internally, which this PR does not resolve. Merely officially supporting Paths for
static_folderneed not require that.)