chore: V4 response specification tests were not being run

Author: rholshausen

core/model/src/main/kotlin/au/com/dius/pact/core/model/V4HttpParts.kt

@@ -235,6 +235,7 @@ data class HttpResponse @JvmOverloads constructor(
   }
 
   companion object {
+    @JvmStatic
     fun fromJson(json: JsonValue): HttpResponse {
       val status = when {
         json.has("status") -> {

pact-specification-test/src/main/resources/v4/response/headers/header value is different case.json

@@ -3,12 +3,12 @@
   "comment": "Headers values are case sensitive",
   "expected" : {
     "headers": {
-      "Accept": "alligators"
+      "X-Accept": "alligators"
     }
   },
   "actual": {
     "headers": {
-      "Accept": "Alligators"
+      "X-Accept": "Alligators"
     }
   }
 }

pact-specification-test/src/test/groovy/specification/BaseResponseSpec.groovy

@@ -1,6 +1,7 @@
 package specification
 
 import au.com.dius.pact.core.model.DefaultPactReader
+import au.com.dius.pact.core.model.HttpResponse
 import au.com.dius.pact.core.support.Json
 import au.com.dius.pact.core.support.json.JsonParser
 import groovy.util.logging.Slf4j
@@ -10,7 +11,7 @@ import spock.lang.Specification
 class BaseResponseSpec extends Specification {
 
   static List loadTestCases(String testDir) {
-    def resources = ResponseSpecificationV1Spec.getResource(testDir)
+    def resources = BaseResponseSpec.getResource(testDir)
     def file = new File(resources.toURI())
     def result = []
     file.eachDir { d ->
@@ -31,4 +32,28 @@ class BaseResponseSpec extends Specification {
     result
   }
 
+  static List loadV4TestCases(String testDir) {
+    def resources = BaseRequestSpec.getResource(testDir)
+    def file = new File(resources.toURI())
+    def result = []
+    file.eachDir { d ->
+      d.eachFile { f ->
+        def json = f.withReader { JsonParser.INSTANCE.parseReader(it) }
+        def jsonMap = Json.INSTANCE.toMap(json)
+        def expected = HttpResponse.fromJson(json.asObject().get('expected'))
+        def actual = HttpResponse.fromJson(json.asObject().get('actual'))
+        result << [
+          d.name,
+          f.name,
+          jsonMap.comment,
+          jsonMap.match,
+          jsonMap.match ? 'should match' : 'should not match',
+          expected,
+          actual
+        ]
+      }
+    }
+    result
+  }
+
 }