feat(api): improve error msg on workflow import (#5288)

yesnault · web-flow · commit d177c8fc71bc · 2020-07-03T09:49:10.000+02:00
diff --git a/engine/api/workflow/dao.go b/engine/api/workflow/dao.go
@@ -842,7 +842,7 @@ func checkHooks(db gorp.SqlExecutor, w *sdk.Workflow, n *sdk.Node) error {
 			h.HookModelID = hm.ID
 		}
 		if h.HookModelName == sdk.RepositoryWebHookModelName && (n.Context == nil || n.Context.ApplicationID == 0) {
-			return sdk.WrapError(sdk.ErrNotFound, "unable to find application for the repository web hook: %d: %s/%s", w.ID, w.Name, n.Name)
+			return sdk.NewErrorFrom(sdk.ErrWrongRequest, "unable to find application for the repository webhook: %s/%s", w.Name, n.Name)
 		}
 
 		// Add missing default value for hook

Original file line number	Diff line number	Diff line change
`@@ -842,7 +842,7 @@ func checkHooks(db gorp.SqlExecutor, w sdk.Workflow, n sdk.Node) error {`
`842`	`842`	`h.HookModelID = hm.ID`
`843`	`843`	`}`
`844`	`844`	`if h.HookModelName == sdk.RepositoryWebHookModelName && (n.Context == nil \|\| n.Context.ApplicationID == 0) {`
`845`		`- return sdk.WrapError(sdk.ErrNotFound, "unable to find application for the repository web hook: %d: %s/%s", w.ID, w.Name, n.Name)`
	`845`	`+ return sdk.NewErrorFrom(sdk.ErrWrongRequest, "unable to find application for the repository webhook: %s/%s", w.Name, n.Name)`
`846`	`846`	`}`
`847`	`847`
`848`	`848`	`// Add missing default value for hook`